From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: [PATCH] fix several memory leaks
Date: Tue, 31 Jul 2018 15:41:10 +0100 [thread overview]
Message-ID: <20180731144111eucas1p21f611a1034776da85bdb7d82028bd264~GexlT_qNQ1387913879eucas1p2p@eucas1p2.samsung.com> (raw)
In-Reply-To: <C23A8FC6-D155-4AFB-8209-B819AF0CAB94@kba.biglobe.ne.jp>
On Tue, 31 Jul 2018 23:30:33 +0900
Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
> > 2018/07/30 22:47, Peter Stephenson <p.w.stephenson@ntlworld.com>
> > wrote:
> >
> > If setupterm(), over which we have no control, is really a problem
> > we probably need a front-end with a lock to make sure it only ever
> > gets called once.
> >
> > Something like a function in utils.c which as the #ifdef buried in
> > it and simply does nothing if we don't HAVE_SETUPTERM, for
> > example?
>
> Ok, it seems we need a reference count of cur_term.
> How about this?
That seems a reasonable solution.
Cheers
pws
prev parent reply other threads:[~2018-07-31 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 16:34 Jun T.
2018-07-28 17:20 ` Jun T.
2018-07-28 18:57 ` Bart Schaefer
2018-08-01 11:14 ` Jun T
2018-07-30 13:47 ` Peter Stephenson
2018-07-31 14:30 ` Jun T.
2018-07-31 14:41 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180731144111eucas1p21f611a1034776da85bdb7d82028bd264~GexlT_qNQ1387913879eucas1p2p@eucas1p2.samsung.com' \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).