From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-43249-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2828 invoked by alias); 6 Aug 2018 15:44:13 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 43249
Received: (qmail 9032 invoked by uid 1010); 6 Aug 2018 15:44:13 -0000
X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.11):SA:0(-6.9/5.0):. 
 Processed in 1.433843 secs); 06 Aug 2018 15:44:13 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham
	autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180806153807euoutp012932dc1d9b8e4be78fdff8d8ce8ee184~IVbAOmbHE1915219152euoutp01R
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;
	s=mail20170921; t=1533569887;
	bh=uwI/xbWrQ/j8aIOyFxwHuF8l+PUoQXiDkgAON/B6f80=;
	h=Date:From:To:Subject:In-Reply-To:References:From;
	b=hWBrRPXD9WWQqhYlsvq40KFXRBLtD0Yc5yuY0ts+mBqq6nA35eD92KB5FlGbIwwoa
	 bHujxurz8jY+sx5P/6pRxSacRQqN6cRY0AXN0SNh0o8QqFxrLsLNCknQDPT0qZ7jiQ
	 6kvQQz82SThRvbh6LunlIGSW5TasQRPPa77wLKH4=
X-AuditID: cbfec7f2-5c9ff70000001159-28-5b686b5e6b20
Date: Mon, 6 Aug 2018 16:38:03 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Anton Shestakov <av6@dwimlabs.net>, <zsh-workers@zsh.org>
Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for
 ->string form
In-Reply-To: <20180806233155.1165c215@neuro>
Organization: SCSC
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsWy7djPc7px2RnRBive8Fp8m5JicbD5IZMD
	k0dn3xZGj1UHPzAFMEVx2aSk5mSWpRbp2yVwZczc2sBSMJW14sihsgbGfpYuRk4OCQETiel/
	drF1MXJxCAmsYJRYsu4rC4TzhVFiw95WKOczo0THqkdMMC3rHr9ihEgsZ5SYfHgDWAKs6n1n
	JUTiNKPEgS2vmCCc84wS2zr+A7VwcLAIqEicfcMJ0sAmYCgxddNsRhBbRMBWounhUmYQW1gg
	TGJ3z3KwAzkFdCTuTj/EBtLKLyAkcaHZFuIIe4mje06C7eUVEJQ4OfMJWDmzgLzE9rdzmEHW
	Sgj8ZpN4tO4+O0RRmcSrOcsZIZpdJA5desgGYQtLvDq+hR3ClpE4PbmHBaK5nVFizaTX7BBO
	D6PEpqN3oLqtJfpuXwR7hllAU2L9Ln0QU0LAUeLnfxsIk0/ixltBiHv4JCZtm84MEeaV6GgT
	gpihJrGjaSvjBEblWUg+mIXkg1kI4xcwMq9iFE8tLc5NTy02zEst1ytOzC0uzUvXS87P3cQI
	TAyn/x3/tIPx66WkQ4wCHIxKPLwc7BnRQqyJZcWVuYcYJTiYlUR4eTOBQrwpiZVVqUX58UWl
	OanFhxilOViUxHn5tNKihQTSE0tSs1NTC1KLYLJMHJxSDYxeu5ROC3iwTLqZdG/ypOuqCxa/
	6z3SxPQ8jq3D7DOb9mvBiXX90xk37U+doWM5n+VZ8dHfZ6qDXA/usshZdHf72tJq60NG9w+e
	Zq35PtforG7vf4aldRcUJxTMVtXYJBm3YHXcu3M6bAxZ8q+6ghxZ/XPlK+/27uBmD1Lf+mbP
	F+e1J8Qtlc8qsRRnJBpqMRcVJwIAh9mZ5wgDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsVy+t/xu7qx2RnRBl07JSy+TUmxONj8kMmB
	yaOzbwujx6qDH5gCmKL0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJS
	czLLUov07RL0MmZubWApmMpaceRQWQNjP0sXIyeHhICJxLrHrxi7GLk4hASWMkpM2bOTHSIh
	I/HpykcoW1jiz7UuNoiij4wST1adZIVwTjNKHFhwnQnCOc8osXrxGqC5HBwsAioSZ99wgnSz
	CRhKTN00mxHEFhGwlWh6uJQZxBYWCJPY3bMc7AxeAWeJT/8ms4LYnAI6EnenH4La9pxZomvv
	BGaQmfwCQhIXmm0hLrKXOLrnJBNEr6DEyZlPwOYwA/WeWHWMGcKWl9j+dg7zBEbhWUjKZiEp
	m4WkbAEj8ypGkdTS4tz03GIjveLE3OLSvHS95PzcTYzAKNl27OeWHYxd74IPMQpwMCrx8HKw
	Z0QLsSaWFVfmHmKU4GBWEuHlzQQK8aYkVlalFuXHF5XmpBYfYjQFhsVEZinR5HxgBOeVxBua
	GppbWBqaG5sbm1koifOeN6iMEhJITyxJzU5NLUgtgulj4uCUamCsKLyrt3TJxydsAozf76VU
	lu6ItL3+/WD6+kvB33XMSjm858nydE1tM0y2KFQ92eguuIurc+VMC8YHO1v+7fP8H/1Ui+tp
	75Jo2bMXUz4e/2Esn3HNZv7HzXeD5jtK8ryYZxuyz6p1ziU1VVYHgxXXynqWMGZU+Vfra7x4
	feJhsPlzycM/Gv8rsRRnJBpqMRcVJwIAfDlPrqgCAAA=
Message-Id: <20180806153805eucas1p2dd7b5d9d279a34337bc1b360dee070d8~IVa_VB8ww2370323703eucas1p2N@eucas1p2.samsung.com>
X-CMS-MailID: 20180806153805eucas1p2dd7b5d9d279a34337bc1b360dee070d8
X-Msg-Generator: CA
Content-Type: text/plain; charset="utf-8"
X-RootMTR: 20180806092113epcas2p1be3488679902085a99d66331745e15d4
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20180806092113epcas2p1be3488679902085a99d66331745e15d4
References: <20180806072813.5051-1-av6@dwimlabs.net>
	<20180806072813.5051-3-av6@dwimlabs.net>
	<CGME20180806092113epcas2p1be3488679902085a99d66331745e15d4@epcas2p1.samsung.com>
	<20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2>
	<20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>
	<20180806190914.246b9514@neuro>
	<1533557076.2551857.1464840032.5374495A@webmail.messagingengine.com>
	<20180806233155.1165c215@neuro>

On Mon, 6 Aug 2018 23:31:55 +0800
Anton Shestakov <av6@dwimlabs.net> wrote:
> I've edited the 2/5 patch to manage local return value based on the
> feedback, and I'll wait until tomorrow in case there's more feedback,
> but for now the question is what people here generally prefer? I can
> resend the whole series, or only changed patches, or I can push to a
> code hosting site or something.

I think we've actually got enough already, though I only use Mercurial
for simple tasks so I don't really know enough to comment on the
user-visible functional aspects.  But if nobody else does we
might just take your word for it and commit them.

pws