From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-43248-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 29905 invoked by alias); 6 Aug 2018 15:32:06 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 43248
Received: (qmail 4038 invoked by uid 1010); 6 Aug 2018 15:32:06 -0000
X-Qmail-Scanner-Diagnostics: from nl.dwimlabs.net by f.primenet.com.au (envelope-from <av6@dwimlabs.net>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(81.4.124.96):SA:0(-1.9/5.0):. 
 Processed in 1.696816 secs); 06 Aug 2018 15:32:06 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,
	SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: av6@dwimlabs.net
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dwimlabs.net;
	s=20171204; t=1533569520;
	bh=D0k3yvGI324XctHRP+W2TXkh4kr9w39fNtGEmvlUbzo=;
	h=Date:From:To:Subject:In-Reply-To:References:From;
	b=XcQ+GsYb9o4M/rNv7I6RxnZYLvmFtGdWa0wGsKNwwb20K3iCYqRBZYBBWd+s8U1RC
	 qoP94H3+PfBH6yH6H9+ce4b1sIphY8NCRwMdb/Wqwj8SrCyBV++InWNfww42oY/sNr
	 36j9dkc0JXswQujeUMRTno3XAdDinLbUthP7yZ80=
Date: Mon, 6 Aug 2018 23:31:55 +0800
From: Anton Shestakov <av6@dwimlabs.net>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for
 ->string form
Message-ID: <20180806233155.1165c215@neuro>
In-Reply-To: <1533557076.2551857.1464840032.5374495A@webmail.messagingengine.com>
References: <20180806072813.5051-1-av6@dwimlabs.net>
	<20180806072813.5051-3-av6@dwimlabs.net>
	<CGME20180806092113epcas2p1be3488679902085a99d66331745e15d4@epcas2p1.samsung.com>
	<20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2>
	<20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com>
	<20180806190914.246b9514@neuro>
	<1533557076.2551857.1464840032.5374495A@webmail.messagingengine.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I've edited the 2/5 patch to manage local return value based on the
feedback, and I'll wait until tomorrow in case there's more feedback,
but for now the question is what people here generally prefer? I can
resend the whole series, or only changed patches, or I can push to a
code hosting site or something.