From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14763 invoked by alias); 13 Aug 2018 11:41:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43281 Received: (qmail 23371 invoked by uid 1010); 13 Aug 2018 11:41:07 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-6.9/5.0):. Processed in 1.400531 secs); 13 Aug 2018 11:41:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180813114100euoutp01e2e05bb15fb97a8989f8b90141077fa5~Kbs_V3YJV0306003060euoutp01v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1534160460; bh=0yA2GsuQzhQU2UY1IVXsgonHWPaFNQG+K1W+KcdbAC4=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=VabMPDd7v8Q2xRtJ8nJJuFXfOCDTymHAEeg5wIYsnXOpKYrhd661Wg1BS48WTGTRX L/Jyjh0y6MkD756lX7Vq4QvowMAa1x+prJQKF8YMexkHdP2FEw7mZdMAnZe+at5QaW 4Dmpl5Ewne3SoJHKm/tk1nHeF1rL4VRjKPTYmvJU= X-AuditID: cbfec7f2-5e3ff70000001159-9b-5b716e4c47bf Date: Mon, 13 Aug 2018 12:40:58 +0100 From: Peter Stephenson To: Guillaume Chazarain , CC: Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt In-Reply-To: <20180813123639.5899f64e@camnpupstephen.cam.scsc.local> Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsWy7djPc7o+eYXRBh8mCli8mfOKyeLtlKNs FgebHzI5MHvsnHWX3WPVwQ9MAUxRXDYpqTmZZalF+nYJXBlb/m1lL9jDVfGi6wVzA+Mqji5G Tg4JAROJd2372bsYuTiEBFYwSmybtxHK+cIo0b97MyOE85lR4tbK+YwwLVu+X2SDSCxnlDgy tZUNruropOtMEM4ZRonjXf+ghl1glOg+2MYM0s8ioCpxbdJzdhCbTcBQYuqm2WBzRQScJGaf eQxmMwtIS3zbcQnMFhbwlHh19jcriM0p4CLRubeHpYuRg4NfQEjiQrMtxEn2Ekf3nGQCsXkF BCVOznzCAjFGXmL72znMIDdICPSzSxxfd4UFoqhM4siCi0A3sAMlXCSme0OMEZZ4dXwLO4Qt I3F6MsgmkNZ2Rok1k16zQzg9jBKbjt6BhoW1RN/ti4wg9zALaEqs36UPEXaUOPd3IRNIWEKA T+LGW0GIc/gkJm2bzgwR5pXoaBOawKgyC8nRs5AcPQth5gJG5lWM4qmlxbnpqcWGeanlesWJ ucWleel6yfm5mxiBieL0v+OfdjB+vZR0iFGAg1GJh7djdUG0EGtiWXFl7iFGCQ5mJRHeCwxA Id6UxMqq1KL8+KLSnNTiQ4zSHCxK4rx8WmnRQgLpiSWp2ampBalFMFkmDk6pBsYF/wOXPTFq ETvySyw1Y3HK7msNL8J8Qis/75rX4jIpb+YSrXrFBSkXj1n4Fb1Y4f6z7YKEhu+aVwlPN3l9 SmfLU859bH02R1Av0dLP9/K7Hdt59p75e7zkashLrtivVZWBHYfsg73Z50a9ydRmdF1tpnKT o2biVvOn25/N+bor8NPD2xvFXCqUWIozEg21mIuKEwG8ANkwEAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t/xe7reeYXRBnfPSVq8mfOKyeLtlKNs FgebHzI5MHvsnHWX3WPVwQ9MAUxRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZG pkr6djYpqTmZZalF+nYJehlb/m1lL9jDVfGi6wVzA+Mqji5GTg4JAROJLd8vsoHYQgJLGSXO Ta6HiMtIfLrykR3CFpb4c60LquYjo8S2b7JdjFxA9hlGiUlvz7FDJC4wSlz4JAtiswioSlyb 9BwsziZgKDF102xGEFtEwEli9pnHYDazgLTEtx2XwGxhAU+JV2d/s4LYvALOEi/X3AeLcwq4 SHTu7WGBWDaJWeJQVydTFyMHB7+AkMSFZluI4+wlju45yQTRKyhxcuYTFoj5OhInVh1jhrDl Jba/ncM8gVFkFpKyWUjKZiEpW8DIvIpRJLW0ODc9t9hQrzgxt7g0L10vOT93EyMwjrYd+7l5 B+OljcGHGAU4GJV4eB+sLYgWYk0sK67MPcQowcGsJMJ7gQEoxJuSWFmVWpQfX1Sak1p8iNEU GDATmaVEk/OBMZ5XEm9oamhuYWlobmxubGahJM573qAySkggPbEkNTs1tSC1CKaPiYNTqoHR /VJCbYgFZ+HhiqqjyiIrTs5OKrhcvVHgQ4cse1bM+vPJ0ysmZDRP1a5sUc+cLjAv3WzXkqtR ju/XPDl6TzrhsNGh7Uu+1IWGnFMUfbSke7/rfumKV68UEv6o2b5UF18jqpKQcSCoxUA45uN9 hwXLvn6zMrVyFVykZ3viUuLDmJUB7cvCVRKUWIozEg21mIuKEwGtUQE5uQIAAA== Message-Id: <20180813114059eucas1p22be8ab1a3db1eafa23a1f30b87418723~Kbs9Rspp11802018020eucas1p2-@eucas1p2.samsung.com> X-CMS-MailID: 20180813114059eucas1p22be8ab1a3db1eafa23a1f30b87418723 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36 References: <20180813084255eucas1p102bc21872ad72a2cd049d8d9db2f0e86~KZResIryo0309103091eucas1p10@eucas1p1.samsung.com> <20180813123639.5899f64e@camnpupstephen.cam.scsc.local> On Mon, 13 Aug 2018 12:36:39 +0100 Peter Stephenson wrote: > On Mon, 13 Aug 2018 13:22:31 +0200 > Guillaume Chazarain wrote: > > On Mon, Aug 13, 2018 at 10:43 AM Peter Stephenson > > wrote: > > > > > The problem with this is all terminals are a bit different in > > > generally undetectable ways > > > > Is there a graphical terminal emulator that works on Linux and that > > does not exhibit the multi-line issue > > ? > > I could reproduce the issue on gnome-terminal, xterm, rxvt. > > And I could also reproduce the issue that the commit fixed: > > http://www.zsh.org/mla/workers/2018/msg00093.html > > So I see a consistent behavior across these 3 terminals. > > So you're saying the commit you say is causing the problem isn't > fixing the problem it was supposed to fix? That implies something > else changed, since dana tried it out at the time and said it worked. > > I will certainly not be jumping into this myself now --- does someone > else want to look? or is this comment from dana about the original patch relevant? > PS: When i was testing it i had changed the comparison in both places; > as mentioned, the patch as submitted only changes the first one. pws