From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: MODERATE for zsh-announce@zsh.org
Date: Wed, 5 Sep 2018 10:14:45 +0000 [thread overview]
Message-ID: <20180905101445.47xb2barz2shlvno@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20180905080711eucas1p10973f35a8405d6dde9801d0078ae02f0~Rcn2AHWZx0648406484eucas1p1A@eucas1p1.samsung.com>
Peter Stephenson wrote on Wed, Sep 05, 2018 at 09:07:09 +0100:
> On Wed, 5 Sep 2018 09:54:15 +0200
> Baptiste Daroussin <bapt@FreeBSD.org> wrote:
> > In case it might help others, the solution to fix the issue and have a working
> > runhelp was to remove the Doc/help.txt file from the sources after extracting
> > the tar file.
>
> Hmm... the help files are supposed to be in the source rather than the
> doc distribution, so logically that should be there (along with the help
> files themselves).
>
I've compared the 5.5.1 artifacts (known good) to the 5.6 artifacts.
The doc tarball adds Etc/FAQ.html, likely due to workers/43333.
The src tarball omits Doc/help/*.
> help.txt gets removed by realclean rather than clean, I think because
> it's part of the source.
>
> Possibly we need to build from realclean when making a tarball.
For the 5.6 artifacts I did an out-of-tree build in an empty builddir after
`git clean -fdx` in the srcdir. The "out-of-tree" part is the problem (I just
did another targz-{src,doc} build to confirm that).
For now, I'll add a note to the rolling-a-release runbook to run the tarball
build in a clean tree using an in-tree build. (I don't have time to fix
Doc/Makefile.in right this minute.)
Sorry for the regression.
Daniel
next prev parent reply other threads:[~2018-09-05 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1536069840.16910.ezmlm@zsh.org>
2018-09-04 14:44 ` Fwd: " Bart Schaefer
2018-09-05 7:54 ` Baptiste Daroussin
2018-09-05 8:07 ` Peter Stephenson
2018-09-05 10:14 ` Daniel Shahaf [this message]
2018-09-05 19:11 ` [PATCH] dist: Generate doc/help/* and doc/help.txt in builddir rather than srcdir Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905101445.47xb2barz2shlvno@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).