zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: zsh 5.6 regression: a pipe sometimes yields a TTOU signal
Date: Wed, 5 Sep 2018 14:21:24 +0100	[thread overview]
Message-ID: <20180905132126eucas1p255bad6207f0b3f35e6ac7395adf3dce1~Rg6OT_Bnt0561505615eucas1p2J@eucas1p2.samsung.com> (raw)
In-Reply-To: <20180905105510.GA2116@cventin.lip.ens-lyon.fr>

I've now been testing with

echo foo | { : | more }

though the exact form isn't going to be important.

My theory is the following is happening:

- Process "echo foo" gets control of the terminal.

- The shell forks ":".  This is group leader for the new pipeline but
doesn't get control of the terminal. Note the { ... } is directly under the control of the main shell, as as is the "echo foo | ..." pipeline.  We
are in the world of nested pipelines.  (Remember "Rimmerworld"? Yes,
exactly.)

- "echo" exits

- The shell looks for a process to attach the tty to and finds ":"
which is currently group leader.

- ":" exits leaving the process group without a leader.

- "more" is forked but doesn't get the TTY because nobody knows no one
ain't got it.  This is different from the case where there's no nested
pipeline.

As evidence, replacing ":" by "sleep 0.01" eliminates the problem (or
"zselect -t 1" which is equivalent --- but it's not just builtins, you
can put a "cat" there, but please don't swing it as you haven't got room,
and the bug still happens).  So I think there's some problem with the way
transferring group leadership (the job gleader struct field) interacts with
attaching the TTY (the call to attachtty()) when we've got a nested
pipeline.

Please tell me someone finds this an interesting problem...

pws

      parent reply	other threads:[~2018-09-05 13:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180905091407epcas1p1ff78da39bfd4f3e4201f467683288a7b@epcas1p1.samsung.com>
2018-09-05  9:03 ` Vincent Lefevre
2018-09-05 10:03   ` Peter Stephenson
2018-09-05 10:55     ` Vincent Lefevre
2018-09-05 12:22       ` Vincent Lefevre
2018-09-05 13:17         ` Vincent Lefevre
2018-09-05 13:37           ` Vincent Lefevre
2018-09-05 14:40             ` Peter Stephenson
2018-09-06 11:40               ` Vincent Lefevre
2018-09-06 12:26                 ` Vincent Lefevre
2018-09-06 12:36                   ` Vincent Lefevre
2018-09-06 12:55                     ` Peter Stephenson
2018-09-05 12:53       ` Peter Stephenson
2018-09-05 13:21       ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180905132126eucas1p255bad6207f0b3f35e6ac7395adf3dce1~Rg6OT_Bnt0561505615eucas1p2J@eucas1p2.samsung.com' \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).