From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43420-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIMWL_WL_MED autolearn=ham autolearn_force=no version=3.4.1 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 22a6006e for ; Sat, 8 Sep 2018 18:40:53 +0000 (UTC) Received: (qmail 9261 invoked by alias); 8 Sep 2018 18:40:41 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43420 Received: (qmail 27335 invoked by uid 1010); 8 Sep 2018 18:40:40 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-1.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(80.0.253.65):SA:0(-1.9/5.0):. Processed in 0.673999 secs); 08 Sep 2018 18:40:40 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Originating-IP: [86.21.219.59] X-Authenticated-User: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=TO5rtWta c=1 sm=1 tr=0 a=utowdAHh8RITBM/6U1BPxA==:117 a=utowdAHh8RITBM/6U1BPxA==:17 a=kj9zAlcOel0A:10 a=x7bEGLp0ZPQA:10 a=PkyFnZI0mBsYe2H--h4A:9 a=CjuIK1q_8ugA:10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com; s=meg.feb2017; t=1536432035; bh=4flh0AznZlQOvaJGPdLnX2vVk6UQaOUGasQq8DyRrHM=; h=Date:From:To:Subject:In-Reply-To:References; b=WThbiUopfbPqXhrHr+N/I2tucUjvAaRf4+EUpVxWTuuKI56FEp7BcfG+hMd9fBT51 8izYq/CXC0w2xHvwC8pgU0aAGSxEvmf92zT1u5TivCjsyKIF3y4HV/ChYTUuZnk+97 Yn9JG7MRq8A2sEnERwgaN8fQCLwKeWFjgVciWOtt0R6RGxhd4aMA+vKIeyOI/AFLN0 46NWcmud9uMIuXHZn6RoRjC+3UivGp0D/Aht3RGmV4treo22MhGrXaSUGTsrGTedi0 Ds+L79lNvHy/zXzp/dJEVGEsIixk76h0e7dkiZxyBW5fpFdFcypDr+9IYmgo8nnAwr j8p1VJLzlqyVg== Date: Sat, 8 Sep 2018 19:40:34 +0100 From: Peter Stephenson To: Zsh hackers list Subject: Re: PATCH: Rimmerworld pipeline race Message-ID: <20180908194034.4154e62a@pws-HP.localdomain> In-Reply-To: <20180908183755.1d187819@pws-HP.localdomain> References: <20180905210740.5a6aec15@pws-HP.localdomain> <20180906090902.1f344e9f@camnpupstephen.cam.scsc.local> <20180906092250eucas1p13d651e07ae627d179dd0701e65f912d6~RxTLztJrP2263722637eucas1p12@eucas1p1.samsung.com> <20180907101852.62415ff9@camnpupstephen.cam.scsc.local> <20180907122145.2af5bcba@camnpupstephen.cam.scsc.local> <20180907150140.46a05880@camnpupstephen.cam.scsc.local> <20180907145828eucas1p2755db3a0eb9725cb3a29121033e77f21~SJhg-Al9h2728227282eucas1p2z@eucas1p2.samsung.com> <577129092.1106031.1536338813897@mail2.virginmedia.com> <20180908183755.1d187819@pws-HP.localdomain> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfP00ENsXerL0coUup7h+pWTSk0M24eLgcyV8wZH1zk7vK4m8AKQqrCA60oksahsrJW/U+cHNa1KLTxfJ/H4aH4IgftqwaCBJE4BJHVBmBO55KGEY7YA1 kL3/g7akEZ/R1WlG4lGCQQBjFm5Rvj0+JYsBI/KmTLjrIv9OgAZV+oQaYkEHznmGGa0Kc5XgLkzp3g== Here's a regression test that seems to work, though the job control tests are rather brittle. Not needed for 5.6.1 as I'm happy this is currently working. pws diff --git a/Test/W02jobs.ztst b/Test/W02jobs.ztst index 1e7ac76c6..98c9f82be 100644 --- a/Test/W02jobs.ztst +++ b/Test/W02jobs.ztst @@ -191,6 +191,14 @@ *>\[2] ? interrupt*sleep* *>\[1] ? kill*sleep* + # Use the shell itself to get interactive output to a terminal. + # It's bizarrely difficult to find a standard programme to do this. + zpty_start + zpty_input "echo | { : | $ZTST_testdir/../Src/zsh -ifc 'print Working'; }" + zpty_stop +0:Regression test for race with process group setting in nested pipeline +>Working + %clean zmodload -ui zsh/zpty