zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: zsh 5.6 doesn't get terminal size change information with "less"
Date: Wed, 12 Sep 2018 09:34:01 +0100	[thread overview]
Message-ID: <20180912083402eucas1p1fa1a8cf61051e237098819076711433d~TmgS2KmsK2054820548eucas1p1b@eucas1p1.samsung.com> (raw)
In-Reply-To: <20180912004421.GA24221@zira.vinc17.org>

On Wed, 12 Sep 2018 02:44:21 +0200
Vincent Lefevre <vincent@vinc17.net> wrote:
> Another major regression in zsh 5.6 and zsh 5.6.1 (tested with both
> xterm and GNOME Terminal):
> 
> 1. Open the terminal to some size.
> 2. View a file with "less" (do not quit).
> 3. Change the size of the terminal.
> 4. Quit "less".
> 
> The terminal becomes unusable (at least if the size has been reduced)
> because zsh did not notice the change. If I echo $COLUMNS and $LINES,
> they still have their old values.

That attachtty() was new back in April --- it needs an
adjustwinsize() alongside it, like many of those in jobs.c.

pws

diff --git a/Src/signals.c b/Src/signals.c
index 20c6fdf..99aad0f 100644
--- a/Src/signals.c
+++ b/Src/signals.c
@@ -550,6 +550,7 @@ wait_for_processes(void)
 			 * leader, however.
 			 */
 			attachtty(mypgrp);
+			adjustwinsize(0);
 		    }
 		}
 	    }

  reply	other threads:[~2018-09-12  8:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180912005142epcas1p1ae6ae9743cca80301c302104047c03c6@epcas1p1.samsung.com>
2018-09-12  0:44 ` Vincent Lefevre
2018-09-12  8:34   ` Peter Stephenson [this message]
2018-09-12 14:12     ` Daniel Shahaf
2018-09-12 14:18       ` Peter Stephenson
2018-09-12 14:24         ` Daniel Shahaf
2018-09-12 14:40           ` Peter Stephenson
2018-09-12 14:57             ` Bart Schaefer
2018-09-12 15:01             ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180912083402eucas1p1fa1a8cf61051e237098819076711433d~TmgS2KmsK2054820548eucas1p1b@eucas1p1.samsung.com' \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).