From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43489-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 86d1ea15 for ; Tue, 18 Sep 2018 18:57:40 +0000 (UTC) Received: (qmail 17021 invoked by alias); 18 Sep 2018 18:57:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43489 Received: (qmail 23582 invoked by uid 1010); 18 Sep 2018 18:57:27 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 6.077571 secs); 18 Sep 2018 18:57:27 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=mX2s3q66QXmLISn0N oT4o+YoilCBFABt1Y1y0mpqeJU=; b=a3G+pdV4+O1NsRvyOFeRcSqZox//xF1tY JkC/ZBo2KpOl46owNepAAk5QAi6BPtD420SMF6QChVPKVoP8wViKtMCx3YhTRfZh 8S7wulbU3v+Anp4oEcHe7BavrnfDImR9JQNf4tIeyal6FNqp5mc3EawEDHlnuzHo O6oX0hXvHFlN/sSN14IAgbRm2UWLqJTLe9UjKK313sE3theybsf2db0OKDv79oVF eVkZhJ095aI7/lp65pdN6HooTeN7t+jwqmxd9EFOZNrhQG1f69eogGqiV2UBnQXL /jeE0kQp+VViMnwthtNeColleE3+Xhp/ZZtT9Qs9MmrjCkYf+aeUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=mX2s3q66QXmLISn0N oT4o+YoilCBFABt1Y1y0mpqeJU=; b=NELGTjGKIxwTECQy9DBQdb7wz/MQzYBTU rNmnLbC/0cV10HYHLe48fKfCTwspp0OWU5efHAw8C8cFz2IP0K4+dZg5GiE3kHXW xxwVQ6Ua+e8cmncsvgHk1nfqksdceD9CQeA2UVt3i7TORHmvhAL4crpIlPV1UcuC Hm1u888t2qKSWkgyxycW53rBHaq/uXnTTFOl7A3QwlYFPfF5yaWWElK647ySamNO /iAynk2NGzYj2gbXwwGwzEgv3pjgbPkUh5o91lvZTe0ADw7uWaLsjJU46tFer0QP xLJp//tE/R38CaWA68zoKB93GsRd8Z1Lz4DaQ8ARhRAHs8B4An6PA== X-ME-Proxy: X-ME-Sender: From: Daniel Shahaf To: zsh-workers@zsh.org Subject: [PATCH] Add error checking on a new write() call. Date: Tue, 18 Sep 2018 18:57:12 +0000 Message-Id: <20180918185712.12060-1-danielsh@tarpaulin.shahaf.local2> X-Mailer: git-send-email 2.11.0 Silences a compiler warning (write(2) is declared with warn_unused_result in current Debian Unstable). --- This is mainly in order to make the build more warning-free, since that write(2) call isn't _that_ likely to fail in practice. Cheers, Daniel Src/exec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Src/exec.c b/Src/exec.c index a667b078d..1d537af24 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -2745,7 +2745,10 @@ execcmd_fork(Estate state, int how, int type, Wordcode varspc, flags |= ESUB_JOB_CONTROL; *filelistp = jobtab[thisjob].filelist; entersubsh(flags, &esret); - write(synch[1], &esret, sizeof(esret)); + if (write_loop(synch[1], (const void *) &esret, sizeof(esret)) != sizeof(esret)) { + zerr("Failed to send entersubsh_ret report: %e", errno); + return -1; + } close(synch[1]); zclose(close_if_forked);