From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Oliver Freyermuth <o.freyermuth@googlemail.com>
Cc: zsh-workers@zsh.org
Subject: Re: zathura conpletion for zsh broken
Date: Tue, 25 Sep 2018 19:21:53 +0000 [thread overview]
Message-ID: <20180925192153.uwitfgrd2yydxtah@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <057ea9a2-d934-59e6-3109-e5093f0f9878@googlemail.com>
Oliver Freyermuth wrote on Tue, Sep 25, 2018 at 17:14:04 +0200:
> +++ b/Completion/X/Command/_zathura
> @@ -25,7 +25,7 @@ _zathura_files(){
> elif [[ $pf =~ "poppler" ]]; then
> supported_filetypes+="pdf"
> else
> - supported_filetypes+="${${pf%.so}#${plugins_dir}/lib}"
> + supported_filetypes+="${${pf%.so}#${plugins_dir}/}"
Isn't this equivalent to «supported_filetypes+=${pf:t:r}»?
The 'break' on line 12 looks odd. Does zathura really ignore
/usr/lib/zathura/foo.so if /usr/local/lib/zathura/bar.so exists and
/usr/local/lib/zathura/foo.so does not?
Thanks,
Daniel
next prev parent reply other threads:[~2018-09-25 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:14 Oliver Freyermuth
2018-09-25 19:21 ` Daniel Shahaf [this message]
2018-09-25 20:02 ` Oliver Freyermuth
2018-09-25 20:36 ` Daniel Shahaf
2018-09-25 21:22 ` Oliver Freyermuth
2018-09-25 22:56 ` Daniel Shahaf
2018-09-26 2:22 ` Oliver Freyermuth
2018-09-26 21:08 ` Leah Neukirchen
2018-09-27 18:20 ` Daniel Shahaf
2018-09-27 18:31 ` Bart Schaefer
2018-09-27 19:16 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925192153.uwitfgrd2yydxtah@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=o.freyermuth@googlemail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).