From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43655-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 74c39fa3 for ; Tue, 9 Oct 2018 09:02:44 +0000 (UTC) Received: (qmail 7111 invoked by alias); 9 Oct 2018 09:02:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43655 Received: (qmail 24494 invoked by uid 1010); 9 Oct 2018 09:02:33 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-7.3/5.0):. Processed in 1.244741 secs); 09 Oct 2018 09:02:33 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181009090228euoutp02fc619487a549bfe52c04a0b482741581~b5T06V1Gg2091820918euoutp02I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1539075748; bh=96SfKCN4ZDQkwuxA2ndAQW3uxI1e7Tnobd3IV4Rw1OQ=; h=Subject:From:To:Date:In-Reply-To:References:From; b=HoWRzM8HZl6Mhe+br6Hs+SJlXZppgn9dP1aaqrIGNOhUjYrA/t5i6HSwpYNhO03Fc LInnUHCk3B9jUSRhSkGSehqGfE+3q2NqB2UUzs0iKZoEEvKWjV/f0sLVzc7T8AjdbC 99oHJxpIbnpIzaJKJpA6bvE1rIg8kjBHmqly9TfM= X-AuditID: cbfec7f4-84fff700000010c6-71-5bbc6ea4bd64 Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues) From: Peter Stephenson To: Date: Tue, 9 Oct 2018 10:02:25 +0100 In-Reply-To: <1539017933.1412806.1534816128.38CEBA8F@webmail.messagingengine.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djP87pL8vZEG8z6wGxxsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4Mvb9ecpasEqgYkvvKtYGxsu8XYycHBICJhJLln1j72Lk4hAS WMEosXzvHzaQhJBAH5PE89ZqiEQvk8Sal10sXYwcYB2vflpDxJczSux7dJMVrujW1vOMEM5p RomF609DzT3PKPGgp5UdZK6wQKTE4/7tjCA2m4ChxNRNs8FsEQFJiWvNp8FsFgEViR03m8Dq OQUCJVYc2sMIcayGxIabx5hAbF4BQYmTM5+wgNjMAvISzVtnM4MskxB4zCbRsvgsG0RRmcTC az9YIZpdJFa3P2WHsIUlXh3fAmXLSPzfOZ8JormdUWLNpNfsEE4Po8Smo3egVltL9N2+yAgK AWYBTYn1u/Qhwo4SSzesZYUEDJ/EjbeCEAfxSUzaNp0ZIswr0dEmBFGtJrGjaSsjRFhG4uka hQmMSrOQfDMLyTezEFYtYGRexSieWlqcm55abJSXWq5XnJhbXJqXrpecn7uJEZgKTv87/mUH 464/SYcYBTgYlXh4Z+TtjhZiTSwrrsw9xCjBwawkwiu6fVe0EG9KYmVValF+fFFpTmrxIUZp DhYlcd5l8zZGCwmkJ5akZqemFqQWwWSZODilGhhDbHZNZ+h6atn8Y3LlxvNnv8bJPq7Kle2b Ptsj7vvWi7d2bRCQ2VO85++Sxm36GXV97yo/tXc/nvPjkH5Bzmcb2wPJB0wqa9VYHZhTpM1P 5yf88bo0cXpuo6O6d2/1Vpaf9+WFZfc8+Gyw9dGK5KRtz0QK5nKa3Sg0XlJ5YUvFk0f8s6qn vLmtxFKckWioxVxUnAgAY2usDAEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4Pd3FeXuiDfYvZrE42PyQyYHRY9XB D0wBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 Gfv+PGUtWCVQsaV3FWsD42XeLkYODgkBE4lXP627GLk4hASWMkq837mNrYuREyguI/Hpykd2 CFtY4s+1LjaIom4miXN3lrFAOKcZJTadngCVOc8ocXrLF7B2XgFDiXVTO8BsYYFIicf92xlB bDag+NRNs8FsEQFJiWvNp8FsFgEViR03m8DWcQoESqw4tAcsLiQwiV3ixrMAEJtZQFOidftv qJM0JDbcPMYEsUtQ4uTMJywQNfISzVtnM09gFJqFpGUWkrJZSMoWMDKvYhRJLS3OTc8tNtQr TswtLs1L10vOz93ECAz+bcd+bt7BeGlj8CFGAQ5GJR7eGXm7o4VYE8uKK3MPMUpwMCuJ8Ipu 3xUtxJuSWFmVWpQfX1Sak1p8iNEU6KGJzFKiyfnAyMwriTc0NTS3sDQ0NzY3NrNQEuc9b1AZ JSSQnliSmp2aWpBaBNPHxMEp1cDoOOV55MOXD1XiN91ZtyFp3+60rqpshoWZckauLZYvkrYf FztgGWiz0FfuiLHJhNgDQT9WyAk6F+xoiGXl3Ba9U8Xk2+SH90L3Tjrz22Dx5IaIaXfYdOM2 NJVyJ0y/VaehXlDGbtC7a+9sVeFHcgY9wZ0pR1d1X55tdcm4RiHdfAu/pvyyqz1KLMUZiYZa zEXFiQAJW1s3lAIAAA== Message-Id: <20181009090227eucas1p173feffa9928dc38719a0f2339a5d04e7~b5TzmA87n2378123781eucas1p1a@eucas1p1.samsung.com> X-CMS-MailID: 20181009090227eucas1p173feffa9928dc38719a0f2339a5d04e7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181007133632epcas5p43a3b4c7f0fe1863478748c5cf46ce8ef X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181007133632epcas5p43a3b4c7f0fe1863478748c5cf46ce8ef References: <20180924210550.carijwjibarjivu4@chaz.gmail.com> <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com> <20181008090557eucas1p11f18ef9ca4a6e3cc09fd59242f344f96~bltk3bsqO1947719477eucas1p1q@eucas1p1.samsung.com> <20181008141056eucas1p2a9a49ec055d2760e87c17832af9f6591~bp33g9vlR0328803288eucas1p2G@eucas1p2.samsung.com> <1539008917.1366329.1534632080.5313528C@webmail.messagingengine.com> <20181008152406eucas1p1660f190ddb4bcd4c0131c4c84492a9f2~bq3vkNlyg2997729977eucas1p1I@eucas1p1.samsung.com> <20181008154932.dvc5q46ylb66j2mm@tarpaulin.shahaf.local2> <20181008164357eucas1p28f2fd7942bffedcc4e769b2ad5d35c51~br9daEJcB1834618346eucas1p2w@eucas1p2.samsung.com> <1539017933.1412806.1534816128.38CEBA8F@webmail.messagingengine.com> On Mon, 2018-10-08 at 16:58 +0000, Daniel Shahaf wrote: > Peter Stephenson wrote on Mon, 08 Oct 2018 17:43 +0100: > So the lex.c error may be an independent issue.  The link to the typeset > change is probably the failure address, 0x3A, which is the hex value of > the ASCII colon character, which is the joinchar of $MANPATH. That's interesting and points to a problem along the lines I suggested --- confusion between special and non-special tied variables.  MANPATH as a special tied variable uses colonarrsetfn() / colonarrgetfn() to set and retrieve values, which uses a colon implicitly, not from the parameter structure.  Non-special tied arrays have a tieddata structure in the data. I didn't get any reaction from the following, however. pws diff --git a/Src/params.c b/Src/params.c index 089a958..b1420f7 100644 --- a/Src/params.c +++ b/Src/params.c @@ -4058,6 +4058,8 @@ char *  colonarrgetfn(Param pm)  {      char ***dptr = (char ***)pm->u.data; +    DPUTS(!(pm->node.flags & PM_SPECIAL), +   "Wrong get fn for npn-special tied array");      return *dptr ? zjoin(*dptr, ':', 1) : "";  }   @@ -4066,6 +4068,8 @@ void  colonarrsetfn(Param pm, char *x)  {      char ***dptr = (char ***)pm->u.data; +    DPUTS(!(pm->node.flags & PM_SPECIAL), +   "Wrong set fn for npn-special tied array");      /*       * We have to make sure this is never NULL, since that       * can cause problems. @@ -4085,6 +4089,7 @@ char *  tiedarrgetfn(Param pm)  {      struct tieddata *dptr = (struct tieddata *)pm->u.data; +    DPUTS(pm->node.flags & PM_SPECIAL, "Wrong get fn for special tied array");      return *dptr->arrptr ? zjoin(*dptr->arrptr, STOUC(dptr->joinchar), 1) : "";  }   @@ -4093,6 +4098,7 @@ void  tiedarrsetfn(Param pm, char *x)  {      struct tieddata *dptr = (struct tieddata *)pm->u.data; +    DPUTS(pm->node.flags & PM_SPECIAL, "Wrong set fn for special tied array");        if (*dptr->arrptr)   freearray(*dptr->arrptr);