[PATCH] _mkdir: support macOS and builtin mkdir

[PATCH] _mkdir: support macOS and builtin mkdir

[Jun T]

mkdir is another command which macOS borrows from FreeBSD.
I'm sending a patch in a separate post because it has another problem:

_mkdir does not work correctly for builtin mkdir (from zsh/files module):

% zmodload zsh/files
% mkdir -<TAB>
this will list long options (--mode and --parents) in addition to -m and -p.

Simple fix is in the patch below; is this OK?


diff --git a/Completion/Unix/Command/_mkdir b/Completion/Unix/Command/_mkdir
index 53536b01d..e4308c304 100644
--- a/Completion/Unix/Command/_mkdir
+++ b/Completion/Unix/Command/_mkdir
@@ -26,7 +26,7 @@ fi
 # Now $variant is set.
 
 case $variant in
-  gnu|freebsd*|dragonfly*)
+  gnu|freebsd*|dragonfly*|darwin*)
     args+=(
       '(-v --verbose)'{-v,--verbose}'[print message for each created directory]'
     )
@@ -42,8 +42,6 @@ case $variant in
       '(- :)--version[display version information]'
     )
   ;;
-  zsh) # remove all options
-  ;;
   *) # non-GNU: remove long options
     args=( ${${${args:#(|*\))--*}//--[^ )]#/}/\( #\)/} )
   ;;

Re: [PATCH] _mkdir: support macOS and builtin mkdir

[Peter Stephenson]

On Tue, 2018-10-23 at 20:23 +0900, Jun T wrote:
> mkdir is another command which macOS borrows from FreeBSD.
> _mkdir does not work correctly for builtin mkdir (from zsh/files module):
> 
> Simple fix is in the patch below; is this OK?

Seems reasonable; it's simple and standard enough there's hardly any
point in writing a special completion.

pws