From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43750-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 912dad00 for ; Thu, 1 Nov 2018 22:30:15 +0000 (UTC) Received: (qmail 10366 invoked by alias); 1 Nov 2018 22:30:01 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43750 Received: (qmail 18113 invoked by uid 1010); 1 Nov 2018 22:30:01 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf1-f176.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.210.176):SA:0(0.2/5.0):. Processed in 2.455482 secs); 01 Nov 2018 22:30:01 -0000 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0CeLiAY2MUk5r4883SVeUBkInuHzLHZ3picPXTH+W6M=; b=SC/PcerTafSih2WCxivM7TyLyEVWk7gxcTBUAjTANaYd2tUBq2RmDwo60CmGSSIQUs XQYBeBrZ9nbwsVYh0roWEEHjPFkZ6630gfs0FSuTg+t8grNlxsutxy1btSUElJc6N3u4 YQ4J2bcafZ2O1E/NwTLc3rR0JVJdM0kB77nU8FedYjCJhaLWRP36gtRsSFpzjlNVUmXP hYukPA1aU7Y7NHer2qRZ7bqDVneFWYxbs62zbf2+pWIcd59TSu85s+/Gn9/o10ZNpD1v 0cDfsRg2BYLBgeVh6Iq5Y9lhegVUGdASHtkV1jpgZfuf3y6z3hRnHDmUKDSb84RNQvoT I5xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=0CeLiAY2MUk5r4883SVeUBkInuHzLHZ3picPXTH+W6M=; b=C9lBdl6ck4BoSgC26nzWYBPMqUOKNYyB5zzJOVZBemI4v1fKsaywnJHpX16Eh8yzC4 WccmeYyOZ3xdYbP84mbtJUGudSk1jtjmVE384kzLFUhWOVI+nTT0KChCKq9qcqWN6wvj nWNX8u/hw+nxwdK08qcduk6v8wTQv8HOicmjc/RdlnKZP8H8u9fRsIlqXx5Zm+ZNGKgg wTKgWD01Xp9Fisn9F0AcJXLKezELrfwzwZmFbbU1fUR/PhuDJpHRVOPdrHqIwshiWmYB ry/oFRID15I5YvI83VYOq5mizh0VCkrja5/Tume9/xpURy2/uFPsC+xocKAMT5MLSudY GFKA== X-Gm-Message-State: AGRZ1gJtxb7E9BnebB6hyUlXQJHI7ZdoLGVKURRGfVA7+PQm4IfJlvp9 HVD+TQsjoKA3GgXKB98cD5U= X-Google-Smtp-Source: AJdET5c1qVv42K3ODP+WL/Gp20gh103Kgsw3S/FdFGREbl0uMA6uzQjKmtpj64AHkHsblR3CYbEEoQ== X-Received: by 2002:a62:1c96:: with SMTP id c144-v6mr9563877pfc.41.1541111395473; Thu, 01 Nov 2018 15:29:55 -0700 (PDT) Date: Thu, 1 Nov 2018 12:29:52 -1000 From: Joey Pabalinas To: Oliver Kiddle Cc: Zsh workers , Joey Pabalinas Subject: Re: PATCH: fix completion for ack 3beta Message-ID: <20181101222952.qdgua4e4odnd2cxk@gmail.com> Mail-Followup-To: Joey Pabalinas , Oliver Kiddle , Zsh workers References: <80802-1541076067.254546@VRCM.-1Xu.KgLD> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vevpcz7if5qrihz5" Content-Disposition: inline In-Reply-To: <80802-1541076067.254546@VRCM.-1Xu.KgLD> User-Agent: NeoMutt/20180716 --vevpcz7if5qrihz5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 01, 2018 at 01:41:07PM +0100, Oliver Kiddle wrote: > The ack completion fails with ack 2.999 because the output from the > --help-types option has very subtly changed (first becomes First). >=20 > Also the ${+commands[${words[1]}]} test is not helpful because that > will always return 0 for full paths - I was trying it with "./ack" > having downloaded the standalone Perl script. >=20 > And while I was looking at it, I've updated the options. Scanned over the diff and the changes look good to me. Trying it out myself also works great, so ACK. --=20 Cheers, Joey Pabalinas --vevpcz7if5qrihz5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlvbfl8ACgkQ2rGdfm9D tVLiMA/+M3Qx5f/u1ScyZQeTlcAEPSu8seO7wgu4/wB/Q8bpfDK/Rl3fl23zu/BQ zaZfNrWMbzdxm2buX+YAfIPczOiwliNd1T3WUoDMSIhPEiJmc4ZeUce2imRWCMLU WQB1dDy3cOF6e0hNHvOIDbRC41OxBwBS1okNc6M/vjV3ktkRolfaN/PO178dolZh z6BQ2zHKy6743ZsubpcHrhqtCBq959+VipCS9YCVkQotrkUTzG0fWz4taul8GZJJ poiUzRPSiw8t7DvusJnCZktvKtxv1NSXJM8CDpBLNkpAHTwpN3RVqwR7osqIYrLt JtTLVraeYauI6U4KRHUqJa2W5qbUmjKgZdSAf8hjgoIZ0YOtlmMJWaXgI8/Agobk MI4v1ulXcCBJ+KWbI3PLmESbYquToRhq9nad93TzEYmpRMRvrJJUmM9QxAsiYYFH VwzhuCVemFopXNPSoWiMGOP1C3oEEPUSWW/w4jpASgXYriv13EtjNhg6fP79E9m/ TtCvLLoCVreN8KCbHw25/22SuNKJCb/emsEgBi/y/gLF/nuruKjPVOyLU4bKFUQH 53Lc5rP5B1WiA2lb1p/7e2WCZyjsyz588ZwHqzmiZ2LNiGgUsEloS43omrfMUzKD 0ZTBpZPAN6vc7YBQOvaJI/ym0/GMoOKgVTRNdFS8jffaSzLMwW8= =ZBMh -----END PGP SIGNATURE----- --vevpcz7if5qrihz5--