zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh list <zsh-workers@zsh.org>
Subject: Re: Non-escaped special chars from var expansion
Date: Sat, 3 Nov 2018 19:49:17 +0000	[thread overview]
Message-ID: <20181103194917.0ac70ef8@pws-HP.localdomain> (raw)
In-Reply-To: <20181102220657.396df24a@pws-HP.localdomain>

On Fri, 2 Nov 2018 22:06:57 +0000
Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> > bindkey '\t' complete-word
> > mkdir 'foo; bar (baz)'
> > cd !:1
> > cd $PWD<tab>
> 
> (Whether the globbing should actually have worked is a question I
> haven't gone into.  But I suspect it's not a problem --- the _expand
> function is trying lots of things not all of which will work.)

In case anyone cares --- no, the glob shouldn't have worked here because
it looks like a bad set of glob qualifiers ("unknown file atribute b").

Next problem is whether it's trying too hard to get glob compilation on
something that's expanded from a variable, without GLOB_SUBST set.
Strictly, I think that probably *is* a problem.  In principle the
quoting should happen on the result of that expansion, and only
if was expanded (from a variable or command or whatever).  I don't think
I'm going down that route myself, however.

Fix so far committed --- I will leave it at that.

pws

  reply	other threads:[~2018-11-03 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 20:39 Wayne Davison
2018-11-02 22:06 ` Peter Stephenson
2018-11-03 19:49   ` Peter Stephenson [this message]
2018-11-02 23:21 ` Wayne Davison
2019-11-17  6:00 ` Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181103194917.0ac70ef8@pws-HP.localdomain \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).