From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4584b7de for ; Fri, 30 Nov 2018 09:55:50 +0000 (UTC) Received: (qmail 18676 invoked by alias); 30 Nov 2018 09:55:35 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43856 Received: (qmail 22980 invoked by uid 1010); 30 Nov 2018 09:55:35 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(210.118.77.12):SA:0(-8.5/5.0):. Processed in 2.888621 secs); 30 Nov 2018 09:55:35 -0000 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181130095526euoutp0203abea08647de4079af9068300802a7d~r3k6eLZJo0700707007euoutp02I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543571726; bh=5WDxKvPZf+b0LVCqY6NrC7m+19IBJoBk8uHRZVIOpBY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Ig6zfM/mSnAYIX3XPZkCuIJpcoZOud6Ecx9NkO7J4f/ZVU+Qduwb+BAbISmOqZMR9 MJG7NxMAUkLO0pELqjWruzziPXmTVBaUzhF3KDLVC8WryDNgRW9ngJFxBfs1avZSP6 tZ6D01jDsTNh08dSRPeXKuBMqPp3orQsbpf677eE= X-AuditID: cbfec7f5-34dff700000012c6-a5-5c01090d8c31 Date: Fri, 30 Nov 2018 09:55:23 +0000 From: Peter Stephenson To: "zsh-workers@zsh.org" Subject: Re: [PATCH 2/2] clear the heredoc list in case par_event() fails Message-ID: <20181130095523.27cf97f4@camnpupstephen.cam.scsc.local> In-Reply-To: Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7djP87q8nIwxBqubxS0ONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxrYjL5gKnnJVLJm4kr2B8RRHFyMnh4SAicSU6e/Zuxi5OIQE VjBKTFt0nAXC6WOS6Nu1GCrTyyRx9+4tVpiWw9OfQFUtZ5SYuOIrI1zV4i3vWSGcM4wS37oa oTIXGCU+3jsA1s8ioCrR+/ocG4jNJmAoMXXTbEYQW0RAX+Lin1tgtrCAp8TFN9fA6nkFnCWO HJzJDmJzCgRKXJh7k6mLkYODX0BI4kKzLcRJ9hJH95xkgigXlDg5E+Q8Tg5mAXmJ7W/nMIPc ICHwnk1i8aM9jBANLhJHVt5ggbCFJV4d38IOYctInJ7cwwLR0M4osWbSa3YIp4dRYtPRO1Dd 1hJ9ty8yglzBLKApsX6XPkTYUeLIxO9sIGEJAT6JG28FIY7gk5i0bTozRJhXoqNNCKJaTWJH 01bGCYzKs5CcPQvJ2bMQ5i9gZF7FKJ5aWpybnlpsnJdarlecmFtcmpeul5yfu4kRmA5O/zv+ dQfjvj9JhxgFOBiVeHgdfv2PFmJNLCuuzD3EKMHBrCTCe66NIUaINyWxsiq1KD++qDQntfgQ ozQHi5I4bzXDg2ghgfTEktTs1NSC1CKYLBMHp1QDY6BNatvXE1PEXxxp73Fl+7Jn+SOu2/HT uD6l/5pcO71wkmXH74hnGZMstk3ND7Nu/n10dYpg0IHq+S9+vzRaGnj0cd8rjZu8187Mfh/j 5bTF7/qhfe8KfM3OHD158L5UVAyvuuZF4w6RdzdiLcvV5p6enOo341+clG7+vWUdevpTHj+p X+P+VVqJpTgj0VCLuag4EQBkHp8EAwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e/4PV0eTsYYg9urZC0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xrYjL5gKnnJVLJm4kr2B8RRHFyMnh4SAicTh6U9Yuhi5OIQEljJKTF5/kQ0iISPx6cpHdghb WOLPtS42iKJuJonb2ydBOWcYJVa2PmGGcC4wSpx7fQGsnUVAVaL39Tkwm03AUGLqptmMILaI gL7ExT+3wGxhAU+Ji2+usYLYvALOEkcOzgRbxykQKHFh7k0miKGtzBKHl38DGsTBwS8gJHGh 2RbiJHuJo3tOMkH0CkqcnAnyAycHs4COxIlVx5ghbHmJ7W/nME9gFJ6FpGwWkrJZSMoWMDKv YhRJLS3OTc8tNtIrTswtLs1L10vOz93ECIyLbcd+btnB2PUu+BCjAAejEg+vw6//0UKsiWXF lbmHGCU4mJVEeM+1McQI8aYkVlalFuXHF5XmpBYfYjQFBsZEZinR5HxgzOaVxBuaGppbWBqa G5sbm1koifOeN6iMEhJITyxJzU5NLUgtgulj4uCUamDc8yCq4/jSN4wy1s3B2s+jHk+3EeaL PpxcYTuV7/vHt4sF7j6bHr7GRzLihVus+Z6COsbHc26fZe/KvPNZ2bMiYK7V9rPC4lXlGq6G ywTllRTTm747/H/OWPjQ56ejWbLrlsRKxys72uKUNtzzeNW/TjDLlklXIs7X/pJMe4f8+0S+ lFfrhJVYijMSDbWYi4oTAb4r7D2hAgAA X-CMS-MailID: 20181130095524eucas1p2e0a41ce300b17aa92432f135b72aed52 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181129163223epcas2p409f7d3c4b9417e2a3a9956abfd64ea3b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181129163223epcas2p409f7d3c4b9417e2a3a9956abfd64ea3b References: <1429277155-24607-1-git-send-email-kdudka@redhat.com> <1429277155-24607-2-git-send-email-kdudka@redhat.com> <20150417201753.41812294@ntlworld.com> <2172016.U8TV6t29ou@kdudka-nb> <1543512844.6025.28.camel@samsung.com> On Thu, 29 Nov 2018 10:39:15 -0800 Bart Schaefer wrote: > On Thu, Nov 29, 2018 at 9:42 AM Peter Stephenson > wrote: > > > > There's some slightly icky linkage between lex errors and the top level > > requiring tok to be LEXERR. The simple fix using the existing > > signalling looks like the following. I definitely don't think the tok = > > LEXERR has a moral right to percolate through in the way it must > > previously have been doing to avoid this, and the lexer does certainly > > have the right to update the token when signalling a parse error, so > > (famous last words) it's hard to see what could be wrong with this... > > Might this need to be conditional upon ... something ... so that e.g. > ${(z)...} on a malformed here-document doesn't throw an error? I > don't have the code handy to poke around. All this change is doing is setting the token to LEXERR in a case which already loudly complains about the error and sets the error flag (this is in a function parsestr() which calls parsetrnoerr() just above). In most cases you'd expect the token in such a case already to be LEXERR: Kamil's test includes an incomplete $( inside a here document so there was some interesting nested parsing involved. So anything reacting badly to the change in the token needs fixing. pws