zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh Workers Mailing List <zsh-workers@zsh.org>,
	Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] zshmisc(1): document implicit append of `term` when `in word` is omitted
Date: Sat, 15 Dec 2018 16:01:27 -1000	[thread overview]
Message-ID: <20181216020127.bdskejrh2ckxrg5n@gmail.com> (raw)
In-Reply-To: <1544925190.621790.1610325216.065C6F48@webmail.messagingengine.com>

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Sun, Dec 16, 2018 at 01:53:10AM +0000, Daniel Shahaf wrote:
> Joey Pabalinas wrote on Sat, 15 Dec 2018 10:26 -1000:
> > This is fairly innocuous behavior and is POSIX-compliant, so document
> > this odd edge case rather than risk regressions attempting to change
> > the lexer/parser code.
> 
> If preventing regressions is your goal, why not add a regression test using this syntax?

Sorry, maybe my commit message was a bit unclear. I meant instead of
trying to poke at the parser/lexer code to make the behavior match the
documentation, I figured it's easier to just do it the other way and
document the weird edge case.

Sorry for the ambiguity (and the double send, forgot to CC the list),
should I revise the commit description?

-- 
Cheers,
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-12-16  2:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15 20:26 Joey Pabalinas
     [not found] ` <1544925190.621790.1610325216.065C6F48@webmail.messagingengine.com>
2018-12-16  2:01   ` Joey Pabalinas [this message]
2018-12-16 11:54     ` Daniel Shahaf
2018-12-16 17:41       ` Peter Stephenson
2018-12-16 19:15       ` Joey Pabalinas
2018-12-16 19:41         ` Bart Schaefer
2018-12-16 22:00           ` Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181216020127.bdskejrh2ckxrg5n@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).