From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: dana <dana@dana.is>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] ztrftime(): Fix truncation for %.
Date: Mon, 24 Dec 2018 17:06:01 +0000 [thread overview]
Message-ID: <20181224170601.i7fiz4zv5fboqtrw@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <4E316F0B-5606-4E93-8988-28A5444612E6@dana.is>
dana wrote on Mon, Dec 24, 2018 at 10:24:16 -0600:
> On 24 Dec 2018, at 06:45, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >Shouldn't the former print [124]?
>
> No, %. only uses the nanoseconds value given to ztrftime(), which is
> implicitly 0 in the former case. It's not substituting an arbitrary series of
> inputs in the style of printf, it only takes those two time arguments to
> ztrftime().
D'oh, thanks.
> +++ b/Src/utils.c
> @@ -3334,19 +3334,22 @@ morefmt:
> #endif
> switch (*fmt++) {
> case '.':
> + {
> if (digs > 9)
> digs = 9;
> + if (ztrftimebuf(&bufsize, digs))
> + return -1;
> + long fnsec = nsec;
> if (digs < 9) {
> int trunc;
> for (trunc = 8 - digs; trunc; trunc--)
> + fnsec /= 10;
> + fnsec = (nsec < 999999500 ? (fnsec + 5) : fnsec) / 10;
> }
Why the magic number 999999500? Why not 999999950 or 999995000 or
99950? And why would it a problem to add 5 when nsec=999999500?
> + sprintf(buf, "%0*ld", digs, fnsec);
> buf += digs;
> break;
> + }
> case '\0':
> /* Guard against premature end of string */
> *buf++ = '%';
next prev parent reply other threads:[~2018-12-24 17:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d7b0451f90bdfe61f48cc1361690180e07158900.camel@ntlworld.com>
[not found] ` <b8851c3a50bd8bceba1961f2f764e1a6869481ac.camel@ntlworld.com>
2018-12-20 22:25 ` The big kre zsh bug report Martijn Dekker
2018-12-21 7:53 ` Bart Schaefer
2018-12-21 8:11 ` Fix for ${\var} oddity Bart Schaefer
2018-12-25 17:18 ` [PATCH] honour NO_UNSET when reading values in arithmetic expansion/commands Martijn Dekker
2018-12-25 20:44 ` 'wait' exit status and warnings [was: The big kre zsh bug report] Martijn Dekker
2018-12-30 18:13 ` Peter Stephenson
2019-01-21 22:53 ` Martijn Dekker
2018-12-31 2:08 ` Line continuation between $ and { " Martijn Dekker
2018-12-21 11:30 ` The big kre zsh bug report Robert Elz
2018-12-21 20:37 ` Bart Schaefer
2018-12-22 0:13 ` Robert Elz
2018-12-21 2:28 ` Robert Elz
2018-12-24 5:40 ` zsh 5.6.2-test-2 Axel Beckert
2018-12-24 7:14 ` Axel Beckert
2018-12-24 7:38 ` dana
2018-12-24 9:16 ` [PATCH] ztrftime(): Fix truncation for % dana
2018-12-24 12:45 ` Daniel Shahaf
2018-12-24 16:24 ` dana
2018-12-24 17:06 ` Daniel Shahaf [this message]
2018-12-24 17:31 ` dana
2018-12-28 22:16 ` dana
2018-12-29 9:55 ` Daniel Shahaf
2018-12-29 10:27 ` Daniel Shahaf
2018-12-29 11:02 ` dana
2018-12-29 11:08 ` Daniel Shahaf
2018-12-29 11:30 ` dana
2018-12-29 11:34 ` Daniel Shahaf
2018-12-24 23:35 ` Joey Pabalinas
2018-12-24 23:30 ` Joey Pabalinas
[not found] ` <CAKc7PVDUjo8HAdwqgRAKcgQHOzThM+hYnjX+2FKzUZB+pfmC-Q@mail.gmail.com>
[not found] ` <CAKc7PVB-agFUarJ=LqC2QNDFta1O5D_o4v-gt7LiobVDohNGVQ@mail.gmail.com>
[not found] ` <06228a6975b91f7066d0046bf912dd69fa5993a2.camel@ntlworld.com>
2018-12-31 13:44 ` zsh 4.6.2-test-2 dana
2018-12-31 15:19 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181224170601.i7fiz4zv5fboqtrw@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=dana@dana.is \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).