From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-44146-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE
	autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 6c32450d
	for <ml@inbox.vuxu.org>;
	Wed, 20 Mar 2019 03:39:07 +0000 (UTC)
Received: (qmail 13868 invoked by alias); 20 Mar 2019 03:38:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 44146
Received: (qmail 22561 invoked by uid 1010); 20 Mar 2019 03:38:56 -0000
X-Qmail-Scanner-Diagnostics: from mail-oi1-f195.google.com by f.primenet.com.au (envelope-from <phy1729@gmail.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.100.2/25391. spamassassin: 3.4.2.  
 Clear:RC:0(209.85.167.195):SA:0(-1.8/5.0):. 
 Processed in 2.979609 secs); 20 Mar 2019 03:38:56 -0000
X-Envelope-From: phy1729@gmail.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.195 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=date:from:to:subject:message-id:mail-followup-to:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=ia7nC+DgMI0v8yzHFCCfzVZ//1Ud9tMN9gpVEWiXmbw=;
        b=cwCK5+NXyl3bUN8LIS/v1mOBbmvl3vZBOSuCIOKUgAQ6u1hJoGt9SILeACD9opsMif
         Q9eeHF7IzZI1igsBCFHq5ptT4TxEFkoMkXKfwPQAN88riRwvTRprIl/vAkNDBqrx2YNS
         5ktMYXGu5TxTkjW3tWHQAWJR9ABIyvjis9p+WnxnTLLrZgpEkA/8CYDFtsb+iVzzM+vK
         Kxc6LsFAVJSKMkTKuhN0zTzDojOKNARHagRlARYEKyzTacQrZ1Vqgjwx7oWTRTpePG1l
         jyFPKRIVC4RITxUnojhMxx8JrBIh2gwmd9kANQivWImLIP3v7TqqAxE8BZDvuh31RF8a
         Ytvw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to
         :references:mime-version:content-disposition:in-reply-to:user-agent;
        bh=ia7nC+DgMI0v8yzHFCCfzVZ//1Ud9tMN9gpVEWiXmbw=;
        b=qBi9OL2/mzEwilqNJWQjxTocHpCqwm7GH8N0KGZ+ErE8xlzPEaVPjwS/9yywlRnE63
         9nLgc4FlXBXcUbRR75aengUpBVHC42NJ+Rl2SQdq4qSxd6K12Qjq+WzjBUoCQwWwjqUI
         pUr6aRisD1WbYfXPuDHLAVEaCSagHqdQ/BtHgO/teImBg1HgU0t1DELAvpkPJ/SLq75V
         UuhxwL8mydVRJxSOnrZ2VEObxU1ZlTZaUtCB6BlruvQVDq73LtcBC8DdOPlLUehU9SrM
         4SmlOuINDEZm3y0JP6yua7y3AxiSVnWLIBX/5pKEHCu878WUc8obX040AFg+q49lHlcu
         dHWA==
X-Gm-Message-State: APjAAAWY+knI6JqRe2GJ+t3VGgd9t0eiuXK+OnKO/1AqwvyCLjA06sW5
	2fmDAuFNbIdMzUPegkXbrdxxkno/
X-Google-Smtp-Source: APXvYqzchiaJsFRYujw06iHvQ2wflGL0hWxqVpty3lkamYNu1+H3OQwZwwwqPOC/jum0hdmyqUq/Ig==
X-Received: by 2002:aca:bfc4:: with SMTP id p187mr3785518oif.36.1553053098799;
        Tue, 19 Mar 2019 20:38:18 -0700 (PDT)
Date: Tue, 19 Mar 2019 22:38:16 -0500
From: Matthew Martin <phy1729@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _pick_variant: Update builtin check
Message-ID: <20190320033815.GA22718@CptOrmolo.darkstar>
Mail-Followup-To: zsh-workers@zsh.org
References: <20190320020511.GA6739@CptOrmolo.darkstar>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190320020511.GA6739@CptOrmolo.darkstar>
User-Agent: Mutt/1.11.4 (2019-03-13)

On Tue, Mar 19, 2019 at 09:05:13PM -0500, Matthew Martin wrote:
> Move the builtin check prior to the cache lookup and don't cache
> builtins if -b is provided. This corrects the result if a user uses both
> a builtin and external version of a command in one shell session.
> 
> The command may be builtin only if all precommands are
> builtin-preserving which are enumerated in builtin_precommands.
> Since a builtin-preserving precommand must be itself builtin, I figure
> it's easier to maintain as a white list. This corrects the case Daniel
> brought up: command chmod <tab>.

I've realized that I was only testing on a system that uses the fallback
variant and the patch will give incorrect results on GNU systems since
_call_program may call a builtin. I'll rework the patch (although I'm
open to suggestions for fixing it).

Sorry for the noise.