From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 3a7831de for ; Sat, 23 Mar 2019 10:13:23 +0000 (UTC) Received: (qmail 15766 invoked by alias); 23 Mar 2019 10:12:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44163 Received: (qmail 21850 invoked by uid 1010); 23 Mar 2019 10:12:40 -0000 X-Qmail-Scanner-Diagnostics: from mail-ed1-f65.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25393. spamassassin: 3.4.2. Clear:RC:0(209.85.208.65):SA:0(-2.0/5.0):. Processed in 1.887929 secs); 23 Mar 2019 10:12:40 -0000 X-Envelope-From: wesleyschwengle@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.208.65 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ENGSQ8+c9mYvHx8+lO5eJqrHALBnKPSR594FmINUss0=; b=L19iT7LfkkrokirV76xKCxQpQHKpbWeQbMpa9dkqPSpE3UbR4D9T/BQMm9NUAN/rCO kdpN/Pzxcn+/LPw96bh5pgPNt/x7bRNZGut+Rqb3CYLmy6zDVS9NHjExlD5DA1F/7wWh 4CNnbv/CjmJFketRadznEl+ZdwR1z0wyv4aa1BYxMcOlKi5SFbuMAqJ1QUdICHDKJuQw 4Kg/nmb0cnG3oXfR+grrtU9XJ5Jv/UeRyTTCf8adhXbOmj2PN8bGwySF0lL5L21bmal3 QGUXHJPF/OvR8PdQ9bHd6br9oLhfQ9Isa6zwa/qbKtmFoj1BtVOlr6lhgMmJAouVNFTn FXWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ENGSQ8+c9mYvHx8+lO5eJqrHALBnKPSR594FmINUss0=; b=GdIYzfJjVHwXmylw8S6ZIUJvMH7ZoMELcwm3WJHYtxJVQz3koC+QiXWfgqMY/aq7j5 rhjpcDb9SYtKh6xMhLYsykVT4IPlk2jYbNUB9eunrKeLvUjCgwZj6s7yeMJNirbV+FIi el46R8cZSo3QzMYyUmSzOwqZ2IMMVwg1lGd6RA85BI7eqeeiroxjMLrde7cN/8G4U9Bw 55k3FLfXXSLhLYPugkWmeM801nwFffvR/JY4DhJ8P4By+EpjXfPRcMnYJOuYgQtblQeN pu9FookpSX9Txk764/VlFb8KCEmnBIRFYICwD03Ew+Xu6c/YiEsoXWowE9f+Dq8vY+8C CbiA== X-Gm-Message-State: APjAAAXKi6j94/XjmGths6NAV/sqUwS85HdLhg/igUtfEzUvPi46vmaJ 0XLONfQYrpyQwTCQMl+9xzL19bx7 X-Google-Smtp-Source: APXvYqyruV2SS1N6KEWCSezD8jxGZlj3lmWRP/fvuh5lgWrZ1ae0BED0jSm1pFPVBIqOJibwIgmWtQ== X-Received: by 2002:a17:906:4cc3:: with SMTP id q3mr8252759ejt.173.1553335924596; Sat, 23 Mar 2019 03:12:04 -0700 (PDT) From: Wesley Schwengle X-Google-Original-From: Wesley Schwengle To: zsh-workers@zsh.org Cc: Wesley Schwengle Subject: [PATCH] Change handrolled strftime to strftime in zftp.c Date: Sat, 23 Mar 2019 11:11:35 +0100 Message-Id: <20190323101135.14344-2-wesley@mintlab.nl> X-Mailer: git-send-email 2.21.0.196.g041f5ea1cf In-Reply-To: <20190323101135.14344-1-wesley@mintlab.nl> References: <20190323101135.14344-1-wesley@mintlab.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmail-Scanner-2.11: added fake Content-Type header Content-Type: text/plain From: Wesley Schwengle Compiling zsh on Debian testing/unstable with cc (Debian 8.3.0-2) 8.3.0 emits a -Wformat-overflow= warning on line 1265 in zftp.c. Replace the code with strftime() resolves it. Signed-off-by: Wesley Schwengle --- Src/Modules/zftp.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Src/Modules/zftp.c b/Src/Modules/zftp.c index 4aaa1f072..e0789216a 100644 --- a/Src/Modules/zftp.c +++ b/Src/Modules/zftp.c @@ -1257,14 +1257,7 @@ zfstats(char *fnam, int remote, off_t *retsize, char **retmdtm, int fd) if (retmdtm) { /* use gmtime() rather than localtime() for consistency */ tm = gmtime(&statbuf.st_mtime); - /* - * FTP format for data is YYYYMMDDHHMMSS - * Using tm directly is easier than worrying about - * incompatible strftime()'s. - */ - sprintf(tmbuf, "%04d%02d%02d%02d%02d%02d", - tm->tm_year + 1900, tm->tm_mon+1, tm->tm_mday, - tm->tm_hour, tm->tm_min, tm->tm_sec); + strftime(tmbuf, 15, "%Y%m%d%H%M%S", tm); mt = ztrdup(tmbuf); } } -- 2.21.0.196.g041f5ea1cf