From: Eric Freese <ericdfreese@gmail.com>
To: zsh-workers@zsh.org
Cc: Eric Freese <ericdfreese@gmail.com>
Subject: [PATCH] Fix ctrl-c not working after process substitution
Date: Tue, 9 Apr 2019 12:34:04 -0600 [thread overview]
Message-ID: <20190409183404.23344-1-ericdfreese@gmail.com> (raw)
This is a potential fix for the ctrl-c problem reported in message 43148
You can reproduce the bug by running `zsh -f`, sourcing the following
.zshrc, and (at the prompt) pressing ^T and then ^C:
foo-request() {
exec {FD}< <(echo foo)
zle -F $FD foo-response
}
foo-response() {
zle -F $1
}
zle -N foo-request
bindkey ^T foo-request
After pressing ^T, ^C doesn't reset the prompt.
I think this is because the forked <(echo foo) process calls
entersubsh() without ESUB_ASYNC flag and so is set as the terminal's
controlling process. My hypothesis is that the original process is never
reset as the terminal's controlling process and thus the SIGINT signals
are no longer sent to the original process.
Adding ESUB_ASYNC flag to the entersubsh() call fixes the issue. I'm not
sure though if there are some cases where we don't want to add the flag
(e.g. when nullexec is 0)?
---
Src/exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Src/exec.c b/Src/exec.c
index 79ef83c1e..6ac852112 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -4984,7 +4984,7 @@ getpipe(char *cmd, int nullexec)
procsubstpid = pid;
return pipes[!out];
}
- entersubsh(ESUB_PGRP, NULL);
+ entersubsh(ESUB_ASYNC|ESUB_PGRP, NULL);
redup(pipes[out], out);
closem(FDT_UNUSED, 0); /* this closes pipes[!out] as well */
cmdpush(CS_CMDSUBST);
--
2.19.0
next reply other threads:[~2019-04-09 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190409183514epcas2p3d19839c97731d5b19dc05586ec9346c7@epcas2p3.samsung.com>
2019-04-09 18:34 ` Eric Freese [this message]
2019-04-10 8:42 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409183404.23344-1-ericdfreese@gmail.com \
--to=ericdfreese@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).