zsh-workers
 help / color / mirror / code / Atom feed
From: Matthew Martin <phy1729@gmail.com>
To: Sam Houston <sehouston3@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Git grep command not interpreting flags correctly when an argument
Date: Sun, 19 May 2019 13:32:11 -0500	[thread overview]
Message-ID: <20190519183210.GA47046@CptOrmolo.darkstar> (raw)
In-Reply-To: <CADbM1Mo6iqa=YcEFCw67FVOhZisX9ioBsdtzTcVmjEOgErebtA@mail.gmail.com>

On Sun, May 19, 2019 at 07:09:22PM +0100, Sam Houston wrote:
> In a `bash` shell, in some empty directory, I can run the commands:
> 
> ```bash
> git init
> echo "pattern" > file.txt
> FLAGS="--untracked --color"
> git grep $FLAGS pattern
> ```
> 
> And see the output:
> 
> ```
> file.txt:pattern
> ```
> 
> But in a `zsh` shell, when I run the same commands, I get the following
> error:
> 
> ```
> error: unknown option `untracked --color'
> ```

The better way (both in zsh and in bash) would be to use an array.

flags=(--untracked --color)
git grep "${flags[@]}" pattern
# git grep $flags pattern   would also work, but just in zsh

Relying on word splitting means that arguments that contain spaces or
other IFS characters are mangled into two or more arguments.

  parent reply	other threads:[~2019-05-19 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 18:09 Sam Houston
2019-05-19 18:14 ` Roman Perepelitsa
2019-05-19 18:32 ` Matthew Martin [this message]
2019-05-19 19:42   ` Sam Houston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190519183210.GA47046@CptOrmolo.darkstar \
    --to=phy1729@gmail.com \
    --cc=sehouston3@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).