From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _make: target: handle "make -C dir"
Date: Fri, 23 Aug 2019 04:48:37 +0000 [thread overview]
Message-ID: <20190823044837.76ulv2oyrtr7xrzj@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20190822063753.25557-1-genml+zsh-workers@thequod.de>
Daniel Hahler wrote on Thu, Aug 22, 2019 at 08:37:53 +0200:
> `$basedir` defaults to `$PWD`, so it is ok to pass it always (I assume).
If the current working directory has been deleted, «$PWD» and «./» may refer to
different directories.
> - _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null)
> + _make-parseMakefile < <(_call_program targets "$words[1]" -C $basedir -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null)
Should be «${(q)basedir}», I presume?
Preexisting issue: the other two parameter expansions should probably
use the «${(q)}» syntax too.
Preexisting issue: the last line of _make-findBasedir should use «print
-r», or better yet, assign to REPLY.
next prev parent reply other threads:[~2019-08-23 4:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:37 Daniel Hahler
2019-08-23 4:48 ` Daniel Shahaf [this message]
2019-08-23 10:40 ` Mikael Magnusson
2019-08-24 16:41 ` Daniel Shahaf
2019-08-24 18:49 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823044837.76ulv2oyrtr7xrzj@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).