From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 471b35f9 for ; Mon, 2 Sep 2019 09:59:07 +0000 (UTC) Received: (qmail 400 invoked by alias); 2 Sep 2019 09:58:57 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44722 Received: (qmail 200 invoked by uid 1010); 2 Sep 2019 09:58:57 -0000 X-Qmail-Scanner-Diagnostics: from hahler.de by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25559. spamassassin: 3.4.2. Clear:RC:0(188.40.33.212):SA:0(-1.6/5.0):. Processed in 2.096517 secs); 02 Sep 2019 09:58:57 -0000 X-Envelope-From: daniel@hahler.de X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.hahler.de designates 188.40.33.212 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thequod.de; h= content-transfer-encoding:content-type:content-type:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=postfix2; t=1567418298; bh=EFJGcG Upp9MAZyUI4w79DBsa0jnitRJA+tiAhXcDqvM=; b=jTMKo35SUtm2jrjKyNMh1k i2brrUn/9SEsBFL0QO2VxxBYTLbFlz09w0Gk34Pz81FZBJAw0Giw7KlPoB9pVtUt kXDOE3vN+CPv5I8bq0nRD3wtEg7TdnRJC8AavF0sWnQjh4EsPGKH0o+xTZ0HLtB4 6BaZgSGaw5koUJS8mR2f0= From: Daniel Hahler To: zsh-workers@zsh.org Subject: [PATCH] _make: use --always-make instead of .PHONY for GNU make Date: Mon, 2 Sep 2019 11:58:16 +0200 Message-Id: <20190902095816.26231-1-genml+zsh-workers@thequod.de> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Daniel Hahler Using ".PHONY" might actually execute (phony) targets then, while "--always-make" triggers processing of all targets, respecting `-n` (`--dry-run`). (This can be seen with `make -nsp .PHONY` in https://github.com/neomake/neomake/tree/76b110d49a, where it actually causes infinite processing then) ".PHONY" was used since the beginning here (37012f06a [1]). As for bmake (which also uses `.PHONY`): there does not appear to be a similar option for it. While it might work better there (i.e. not causing targets to be run), it causes an error at least when testing it quickly - which indicates that it behaves as if using any other non-existing (or special) target there maybe: > bmake: don't know how to make .PHONY. Stop This was added in ecc0a5ece [2] (workers-39654). Since it uses `-s -f "$file" -V.ALLTARGETS` with `bmake` before to get targets explicitly, there might not be a reason for calling `bmake` with `-nsdg1Fstdout … .PHONY` additionally in the first place?! 1: https://github.com/danielshahaf/zsh/commit/37012f06a 2: https://github.com/danielshahaf/zsh/commit/ecc0a5ece --- Completion/Unix/Command/_make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make index e23906373..56d47f4ea 100644 --- a/Completion/Unix/Command/_make +++ b/Completion/Unix/Command/_make @@ -262,7 +262,7 @@ _make() { if [[ $is_gnu == gnu ]] then if zstyle -t ":completion:${curcontext}:targets" call-command; then - _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null) + _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" --always-make 2> /dev/null) else _make-parseMakefile < $file fi -- 2.23.0