zsh-workers
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: zsh-workers@zsh.org
Subject: [PATCH 0/1] Run final pipeline command in a subshell in sh mode
Date: Sun, 24 Nov 2019 23:41:18 +0000	[thread overview]
Message-ID: <20191124234119.2403456-1-sandals@crustytoothpaste.net> (raw)

POSIX sh implementations run each command in a pipeline in a subshell,
although zsh (and AT&T ksh) do not: instead, they run the final command
in the main shell.

zsh is starting to be used in some cases as /bin/sh, such as on macOS
Catalina.  Whether this is a good idea or not, it makes sense to emulate
the POSIX behavior as much as possible when emulating sh, since that's
the least surprising behavior.  This patch does exactly that.

With this patch, using "zsh --emulate sh" passes all but one test of the
Git testsuite.  The remaining failure is due to zsh preserving NUL bytes
in the output of command substitutions, which is permitted by POSIX; I
will be sending a patch to fix that bug in the Git testsuite.

I will admit that some of the tests included look bizarre, such as
piping to an assignment, but I felt it was important to hit as many
cases as possible.

I'm not subscribed to the list, so please CC me with any comments, and
I'll try to address them promptly.  If you'd like me to include a
changelog entry, please say so, and I'm happy to include one.

brian m. carlson (1):
  exec: run final pipeline command in a subshell in sh mode

 Src/exec.c           | 10 ++++++----
 Test/B07emulate.ztst | 22 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 4 deletions(-)


             reply	other threads:[~2019-11-24 23:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 23:41 brian m. carlson [this message]
2019-11-24 23:41 ` [PATCH 1/1] exec: run " brian m. carlson
2019-12-07 19:23 ` [PATCH 0/1] Run " brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191124234119.2403456-1-sandals@crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).