From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Aleksandr Mezin <mezin.alexander@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] vcs_info: choose the nearest repository
Date: Mon, 25 Nov 2019 04:33:21 +0000 [thread overview]
Message-ID: <20191125043321.hvbaerubneh2gcon@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20191123221443.279556-4-mezin.alexander@gmail.com>
Aleksandr Mezin wrote on Sun, Nov 24, 2019 at 04:14:43 +0600:
> However, this logic may not work correctly for symlinked repositories, if
> VCS_INFO_detect_* functions will continue to use :P modifier for the basedir.
> Is there a reason why :P is used for basedir instead of :a?
If ${foo} exists, then ${foo} and ${foo:P} are guaranteed to point to the same
inode. That's not true for ${foo} and ${foo:a}. What problem do you see with
use of :P? Shouldn't your 3/3 patch use :P rather than :a?
> +++ b/Functions/VCS_Info/vcs_info
> @@ -117,15 +116,25 @@ vcs_info () {
> fi
> vcs_comm=()
> VCS_INFO_get_cmd
> - VCS_INFO_detect_${vcs} && (( found = 1 )) && break
> + if VCS_INFO_detect_${vcs}; then
> + if (( ${#vcs_comm[basedir]:a} > ${#nearest_vcs_comm[basedir]:a} )); then
If $vcs_comm[basedir] is /foobar and $nearest_vcs_comm[basedir] is /foo, the
condition would be true but there'd be no parent dir–subdir relationship
between the two values.
> + nearest_vcs_comm=("${(kv)vcs_comm[@]}")
> + nearest_vcs="${vcs}"
> + nearest_backend_misc=("${(kv)backend_misc[@]}")
> + fi
> + fi
> done
Cheers,
Daniel
prev parent reply other threads:[~2019-11-25 4:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 22:14 [PATCH 0/3] vcs_info: handle nested repositories of different types Aleksandr Mezin
2019-11-23 22:14 ` [PATCH 1/3] vcs_info/git: set vcs_comm[basedir] in VCS_INFO_detect_git Aleksandr Mezin
2019-11-23 22:14 ` [PATCH 2/3] vcs_info/cvs: set vcs_comm[basedir] in VCS_INFO_detect_cvs Aleksandr Mezin
2019-11-25 4:35 ` Daniel Shahaf
2019-11-25 7:31 ` Aleksandr Mezin
2019-11-25 8:16 ` Daniel Shahaf
2019-11-26 1:26 ` Aleksandr Mezin
2019-11-26 1:28 ` Aleksandr Mezin
2019-11-26 4:52 ` Daniel Shahaf
2019-11-26 10:22 ` Aleksandr Mezin
2019-11-28 11:13 ` Daniel Shahaf
2019-11-28 21:34 ` Daniel Shahaf
2019-11-29 13:41 ` Aleksandr Mezin
2019-11-29 15:25 ` Mikael Magnusson
2019-11-29 19:55 ` Daniel Shahaf
2019-11-29 20:30 ` Daniel Shahaf
2019-11-29 20:52 ` Daniel Shahaf
2019-11-25 9:13 ` Bart Schaefer
2019-11-25 18:22 ` Daniel Shahaf
2019-11-25 18:47 ` Bart Schaefer
2019-11-23 22:14 ` [PATCH 3/3] vcs_info: choose the nearest repository Aleksandr Mezin
2019-11-25 4:33 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125043321.hvbaerubneh2gcon@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=mezin.alexander@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).