From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 403028ef for ; Mon, 25 Nov 2019 04:36:06 +0000 (UTC) Received: (qmail 350 invoked by alias); 25 Nov 2019 04:36:01 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44928 Received: (qmail 26324 invoked by uid 1010); 25 Nov 2019 04:36:01 -0000 X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25642. spamassassin: 3.4.2. Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. Processed in 0.730538 secs); 25 Nov 2019 04:36:01 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm1; bh=Tgn asbfkncr8KTlBz4dPSpxmZjUJWJpcoxRdvXkCOg0=; b=WOjGF8bJ1CpLAqWIY6v uCGLmqswjymzKYGBLOUj0CX+93RY0qPPM26IqrFYUQhN6XEbR+hDuaOV8aYiBTQ5 bHx5/Bvxnl9/WaFBhMaDWHb6ROPKWkLUpi8LJyZACMESMtNSukfY5eeGLKiIpt4d fwJ14ah4HKN4WsimK1uLgxqHrWuGC094keIiyeZhFqs3qspEPJxYSKccxLacI/u/ Fs5aZo3BsTKazIxfVYMs0qCFpbO+mfq1jj8Yi2TS4jmWdwSPn7nu/Poa/lQNxhdy xtuSqqSuxEziMBfnhg1paQriGRiVYL1UkcYco4kaqIQkC2NuzA+zBPqYQLQoMA5C xeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Tgnasb fkncr8KTlBz4dPSpxmZjUJWJpcoxRdvXkCOg0=; b=CGPv3oObYPTksCvwgN2Vkb kam7lAq/cmdOIKq7UC+omwMGX9qZYtg3CP2YhFaoiq7KD0Wf4dOquz5+BDghF7sM e1teMkz6b8Hf+16KPBs1a0iTwI1XmtNK1JgBpB7m6AMvZt0iTxO6zuzGJeK5shQA 1m4+WMG1paCP29F18WWGXzXvDpxxTOmbumcjZNXYlFom3V3NLReQvsY4rhkUpVB+ 3lSyvoynjWx3LwKGG6nES7r/LluS3t4fUfPnmwmhpC4qgkn+HDDDDRk+jTrCLb9E OsIE012OEuswL9r1QHJStBXev1MUHfrOfCJ4D1lZS8ulep+vBygR7RRbIbbkUGPA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeitddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdttddttdervdenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cukfhppeejledrudektddrheejrdduudelnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu rdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgenucevlhhushhtvghrufhiiigvpe dt X-ME-Proxy: Date: Mon, 25 Nov 2019 04:35:25 +0000 From: Daniel Shahaf To: Aleksandr Mezin Cc: zsh-workers@zsh.org Subject: Re: [PATCH 2/3] vcs_info/cvs: set vcs_comm[basedir] in VCS_INFO_detect_cvs Message-ID: <20191125043525.lcxm532gi6hb7n53@tarpaulin.shahaf.local2> References: <20191123221443.279556-1-mezin.alexander@gmail.com> <20191123221443.279556-3-mezin.alexander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191123221443.279556-3-mezin.alexander@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Aleksandr Mezin wrote on Sun, Nov 24, 2019 at 04:14:42 +0600: > +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_cvs > @@ -5,11 +5,7 @@ > -cvsbase="." > -while [[ -d "${cvsbase}/../CVS" ]]; do > - cvsbase="${cvsbase}/.." > -done > +++ b/Functions/VCS_Info/Backends/VCS_INFO_detect_cvs > @@ -7,5 +7,12 @@ setopt localoptions NO_shwordsplit > +local cvsbase="." > +while [[ -d "${cvsbase}/../CVS" ]]; do > + cvsbase="${cvsbase}/.." > +done I know you just moved this code around, but I'd like to point out that it causes an infinite loop when /CVS exists. Cheers, Daniel