From: Lars Wendler <polynomial-c@gentoo.org>
To: zsh-workers@zsh.org
Cc: Lars Wendler <polynomial-c@gentoo.org>, Tetja Rediske <tetja@tetja.de>
Subject: [PATCH] configure.ac: check for has_colors symbol in curses lib
Date: Wed, 11 Dec 2019 16:55:07 +0100 [thread overview]
Message-ID: <20191211155507.22181-1-polynomial-c@gentoo.org> (raw)
Otherwise zsh/curses module won't get built if ncurses was built with
separate tinfo lib.
One could still force-build the module but loading it later yields the
following error message:
failed to load module `zsh/curses': /usr/lib64/zsh/5.7.1/zsh/curses.so:
undefined symbol: COLORS
That is because the final linker call requires -lncurses(w) but it only
contains -ltinfo(w).
Reported-by: Tetja Rediske <tetja@tetja.de>
See-also: http://www.zsh.org/mla/users/2016/msg01097.html
Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 8fd4d452f..9623133f0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -816,6 +816,7 @@ AC_SEARCH_LIBS(tgetent, [$termcap_curses_order],
This is probably a library called 'curses' or 'ncurses'. You may
need to install a package called 'curses-devel' or 'ncurses-devel' on your
system."], 255))
+AC_SEARCH_LIBS(has_colors, [$termcap_curses_order])
AC_CHECK_HEADERS(curses.h, [],
[AC_CACHE_CHECK(for Solaris 8 curses.h mistake, ac_cv_header_curses_solaris,
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <curses.h>]], [[]])],[ac_cv_header_curses_h=yes
--
2.24.1
next reply other threads:[~2019-12-11 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:55 Lars Wendler [this message]
2020-04-25 9:49 ` Daniel Shahaf
2020-04-25 10:24 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211155507.22181-1-polynomial-c@gentoo.org \
--to=polynomial-c@gentoo.org \
--cc=tetja@tetja.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).