From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org, dana <dana@dana.is>
Subject: Re: TR : Re : [BUG] Crash due to malloc call in signal handler
Date: Mon, 16 Dec 2019 04:00:43 +0000 [thread overview]
Message-ID: <20191216040043.rnhdqwmxni5ucpos@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <5768d5ca6d1e70c3b7c58b87ca99410f6306a584.camel@ntlworld.com>
Peter Stephenson wrote on Sun, Dec 15, 2019 at 19:06:43 +0000:
> On Sat, 2019-12-14 at 12:32 +0000, Peter Stephenson wrote:
> > On Fri, 2019-12-13 at 21:08 +0000, Peter Stephenson wrote:
> > > On Fri, 2019-12-13 at 17:30 +0000, Peter Stephenson wrote:
> > > > I think the intention here is to make sure we're not blocking for a long
> > > > time in this function, but if fgetc() is doing memory allocation we're
> > > > going to have to put that in the signal blocking. However, if the input
> > > > itself blocks in fgetc() that's going to be a problem. The fix might be
> > > > not to fdopen() the input file, but just read into a buffer with
> > > > read().
> > >
> > > This would look like the following, which is passing tests...
> >
> > Slight update to close the file descriptor and to document the arguments
> > of the function.
>
> I've committed this --- and as it's potentially serious we should let it
> get a bit of testing and then get it into the release --- but as I've
> still had no comments further examination is still welcome.
I'm installing it as my day-to-day shell right now.
Does this warrant a 5.7.1-test-2 before 5.8?
next prev parent reply other threads:[~2019-12-16 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191213171028eucas1p2e7820377701008b2d05c898192b7c17e@eucas1p2.samsung.com>
2019-12-13 17:09 ` Antoine C.
2019-12-13 17:30 ` Peter Stephenson
2019-12-13 21:08 ` Peter Stephenson
2019-12-14 12:32 ` Peter Stephenson
2019-12-15 19:06 ` Peter Stephenson
2019-12-16 4:00 ` Daniel Shahaf [this message]
2019-12-16 10:05 ` Peter Stephenson
2019-12-13 21:10 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216040043.rnhdqwmxni5ucpos@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=dana@dana.is \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).