From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-45140-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 6f2a89f3
	for <ml@inbox.vuxu.org>;
	Tue, 24 Dec 2019 23:33:41 +0000 (UTC)
Received: (qmail 16496 invoked by alias); 24 Dec 2019 23:33:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45140
Received: (qmail 23071 invoked by uid 1010); 24 Dec 2019 23:33:24 -0000
X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.1/25670. spamassassin: 3.4.2.  
 Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. 
 Processed in 4.544854 secs); 24 Dec 2019 23:33:24 -0000
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
X-ME-Sender: <xms:G6ACXq-BmUaJlbRmmtiXYIXvFkLLFmrCc_9TPcHEmLaTxk83XVP9pg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddvvddguddujecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesth
    dttddttdervdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn
    ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudektddrheejrdduudelne
    curfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhn
    rghmvgenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:G6ACXo4kYsPWWO8cNFwa0_MIJVmp2u6jljIM20bmc9feZ42XDlJZMw>
    <xmx:G6ACXmUJ92Yvw4BeTNy8hRrPMSkad7zyTiv5SMOxNgy97TSAdWEFoQ>
    <xmx:G6ACXmWDHOzRw2JXEuiwWbH5yHmLfK-Os7G66qmPHmNkrWUzYZ0qHg>
    <xmx:G6ACXtXNvsd3oNBXZaG7oVGXYpGvjxya3gVkO214BX7GRRU_vr-9xQ>
Date: Tue, 24 Dec 2019 23:32:40 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: ${(z)} parsing of multiple array assignments
Message-ID: <20191224233240.2unonfvs7tjzg2jp@tarpaulin.shahaf.local2>
References: <20191223173115.bvhwbpfmqgqhngle@tarpaulin.shahaf.local2>
 <20191224203408.GA35101@osmium.pennocktech.home.arpa>
 <CAKc7PVCKy2ubK3SybpVAAqpOzqGDcL0LJ=TYN4fAPLMhkyJ3-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKc7PVCKy2ubK3SybpVAAqpOzqGDcL0LJ=TYN4fAPLMhkyJ3-A@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)

Sebastian Gniazdowski wrote on Wed, Dec 25, 2019 at 00:16:09 +0100:
> % x='a=(foo) b=() d=(bar)'
> % print -rl -- "${(z)x}"

Breadcrumb:

[[[
diff --git a/Src/lex.c b/Src/lex.c
index 1d86da94e..e6f6c8f50 100644
--- a/Src/lex.c
+++ b/Src/lex.c
@@ -340,13 +340,13 @@ ctxtlex(void)
     case ELIF:
     case ELSE:
     case DOUTBRACK:
+    case OUTPAR:
 	incmdpos = 1;
 	break;
     case STRING:
     case TYPESET:
  /* case ENVSTRING: */
     case ENVARRAY:
-    case OUTPAR:
     case CASE:
     case DINBRACK:
 	incmdpos = 0;
]]]

This change fixes all the cases in this thread, and passes all zsh tests and
all z-sy-h tests (which rely heavily on ${(z)} functioning correctly); however,
I don't know whether it's correct.

I'm guessing that the different meaning of parentheses are being confused for
each other:

- Array assignment
- End of subshell
- Function defnition
- Glob qualifier

Thanks,

Daniel