From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 075e975b for ; Wed, 1 Jan 2020 12:53:04 +0000 (UTC) Received: (qmail 24714 invoked by alias); 1 Jan 2020 12:52:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45178 Received: (qmail 25110 invoked by uid 1010); 1 Jan 2020 12:52:59 -0000 X-Qmail-Scanner-Diagnostics: from wout2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25677. spamassassin: 3.4.2. Clear:RC:0(64.147.123.25):SA:0(-2.6/5.0):. Processed in 5.145018 secs); 01 Jan 2020 12:52:59 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdefledggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudektddrheejrdduudelne curfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhn rghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Date: Wed, 1 Jan 2020 12:52:13 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] coding practice in examples (-- with globs mostly) Message-ID: <20200101125213.fo75ca2wdkwrbzi4@tarpaulin.shahaf.local2> References: <20191231091618.v2erkblkwkiy3i5a@chaz.gmail.com> <20191231171638.en6olco722w4ldcc@tarpaulin.shahaf.local2> <20200101120009.24l375svthztyszj@chaz.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200101120009.24l375svthztyszj@chaz.gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Stephane Chazelas wrote on Wed, Jan 01, 2020 at 12:00:09 +0000: > 2019-12-31 17:16:38 +0000, Daniel Shahaf: > [...] > > > {+++ b/Doc/Zsh/contrib.yo+} > > > @@ -4422,10 +4422,11 @@ For example, to get a long tt(ls) listing of all plain files in the > > > current directory or its subdirectories: > > > > > > example(autoload -U zargs > > > zargs -- **/*(.) -- ls [--l)-] {+-ld --)+} > > > > > > Note that `tt(-)tt(-)' is used both to mark the end of the var(option) > > > list and to mark the end of the var(input) [-list,-] {+list (and here also to mark > > > the end of the option list for tt(ls)),+} so it must appear twice > > > whenever the var(input) list may be empty. If there is guaranteed to be > > > at least one var(input) and the first var(input) does not begin with a > > > `tt(-)', then the first `tt(-)tt(-)' may be omitted. > > > > I think the text could be a little hard to follow, since there are three > > «--» but it talks about "both" and then mentions the third in an > > afterthought. Would you prefer to change the incumbent text as well? > > You're not limited to adding parentheticals. > > I see what you mean. How about something like: > > zargs -- **/*(.) -- ls -ld -- > > The first and third occurrences of -- are used to mark the end > of options for zargs and ls respectively to guard against > filenames starting with -, while the second is used to separate > the list of files from the command to run. > > The first -- would also be needed if there was a chance the list > might be empty as in: > > zargs -r -- ./*.back(#qN) -- rm -f Looks good, thanks. Please commit. Further suggestions (nice-to-have's, not blockers): - Clarify that the third -- isn't syntactically significant, and is just passed to ls verbatim. - Use an example with two --'s before an example with three --'s. Cheers, Daniel