From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 5db3dddd for ; Fri, 3 Jan 2020 21:05:16 +0000 (UTC) Received: (qmail 2815 invoked by alias); 3 Jan 2020 20:09:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45213 Received: (qmail 19423 invoked by uid 1010); 3 Jan 2020 20:09:28 -0000 X-Qmail-Scanner-Diagnostics: from wout4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25677. spamassassin: 3.4.2. Clear:RC:0(64.147.123.20):SA:0(-1.9/5.0):. Processed in 7.978343 secs); 03 Jan 2020 20:09:28 -0000 X-Envelope-From: danielsh@apache.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: softfail (ns1.primenet.com.au: transitioning SPF record at amazonses.com does not designate 64.147.123.20 as permitted sender) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdegfedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecuogfggedutddqvdejucdlgedtmdenucfjughrpe fhvffufffkofestddtredtredttdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcu oegurghnihgvlhhshhesrghprggthhgvrdhorhhgqeenucfkphepjeelrddukedtrdehje drudduleenucfrrghrrghmpehmrghilhhfrhhomhepuggrnhhivghlshhhsegrphgrtghh vgdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: From: Daniel Shahaf To: zsh-workers@zsh.org Subject: [PATCH] Make --enable-gdbm default to false, rather than default to true with an unavoidable warning. Date: Fri, 3 Jan 2020 20:08:42 +0000 Message-Id: <20200103200842.10414-1-danielsh@apache.org> X-Mailer: git-send-email 2.11.0 --- As the subject says. If it's something the user might not want to do, make it opt-in. Also, there was no way for a user who understood the implications to turn off the warning. Cheers, Daniel README | 4 ++++ configure.ac | 14 +++----------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/README b/README index 5d9d9073a..5ae6087a2 100644 --- a/README +++ b/README @@ -33,6 +33,10 @@ details, see the documentation. Incompatibilities since 5.7.1 ----------------------------- +Build-time change: The default value of the --enable-gdbm configure +argument has changed from "yes" to "no". Thus, the zsh/db/gdbm module will +not be built unless --enable-gdbm is passed explicitly. + The history expansion !:1:t2 used to be interpreted such that the 2 was a separate character added after the history expansion. Now it is an argument to the :t modifier. diff --git a/configure.ac b/configure.ac index 8fd4d452f..256584538 100644 --- a/configure.ac +++ b/configure.ac @@ -444,9 +444,10 @@ dnl Do you want to look for capability support? AC_ARG_ENABLE(cap, AS_HELP_STRING([--enable-cap],[enable the search for POSIX capabilities (may require additional headers to be added by hand)])) +# Default off for licensing reasons AC_ARG_ENABLE(gdbm, -AS_HELP_STRING([--disable-gdbm],[turn off search for gdbm library]), -[gdbm="$enableval"], [gdbm=yes]) +AS_HELP_STRING([--enable-gdbm],[enable the search for the GDBM library (see the zsh/db/gdbm module)]), +[gdbm="$enableval"], [gdbm=no]) dnl ------------------ dnl CHECK THE COMPILER @@ -3298,13 +3299,4 @@ fi echo "See config.modules for installed modules and functions. " -case x$LIBS in - *-lgdbm*) - echo "WARNING: zsh will be linked against libgdbm. -This means the binary is covered by the GNU General Public License. -This does not affect the source code. -Run configure with --disable-gdbm if required." - ;; -esac - exit 0