From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id cf65f0a3 for ; Fri, 3 Jan 2020 21:05:34 +0000 (UTC) Received: (qmail 23578 invoked by alias); 3 Jan 2020 20:11:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45214 Received: (qmail 18540 invoked by uid 1010); 3 Jan 2020 20:11:38 -0000 X-Qmail-Scanner-Diagnostics: from wout4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25677. spamassassin: 3.4.2. Clear:RC:0(64.147.123.20):SA:0(-2.6/5.0):. Processed in 0.77989 secs); 03 Jan 2020 20:11:38 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdegfedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecuogfggedutddqvdejucdlgedtmdenucfjughrpe ffhffvuffkfhggtggugfgjfgesthektddttderudenucfhrhhomhepffgrnhhivghlucfu hhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppe ejledrudektddrheejrdduudelnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegu rghnihgvlhdrshhhrghhrghfrdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Date: Fri, 3 Jan 2020 20:11:02 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) Message-ID: <20200103201102.o7ezzd6ccxxih7fb@tarpaulin.shahaf.local2> References: <20200101134457.kdzfrmlyzjwptxaz@tarpaulin.shahaf.local2> <64e62682e403332a89322b7f24983fa009c19fc0.camel@ntlworld.com> <46b2aa40-adcb-44ff-8e39-df98a9b2d235@www.fastmail.com> <1578046551.4581.1.camel@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1578046551.4581.1.camel@samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) --- Peter Stephenson wrote on Fri, Jan 03, 2020 at 10:15:51 +0000: > On Thu, 2020-01-02 at 11:30 +0000, Daniel Shahaf wrote: > > A build-time warning, then?  I.e., have configure warn if --disable-multibyte > > is selected (manually or automatically), or perhaps use a #warning at > > the C level.  It could say something to the effect of "Compiling without > > multibyte support is known not to pass 'make test'.  We recommend to > > rebuild with --enable-multibyte.  Alternatively, fix the test suite and > > send us the patches". > >  > > This will at least make the issue known to anyone who tries to disable > > multibyte support for whatever reason. > > It sounds like a pretty sensible idea to mention this at the end of the > configure output, where there are a couple of other messages for issues > (typically linking but anything configuration related would seem to be > appropriate). Here's a draft. Probably needs wordsmithing. Cheers, Daniel (This patch was written on top of the gdbm patch I just posted, but they can be applied independently of each other.) diff --git a/configure.ac b/configure.ac index 256584538..cd42a789e 100644 --- a/configure.ac +++ b/configure.ac @@ -2553,6 +2553,7 @@ wmemcpy wmemmove wmemset; do AC_MSG_NOTICE([all functions found, multibyte support enabled]) zsh_cv_c_unicode_support=yes else + # Warns at the end of configure AC_MSG_NOTICE([missing functions, multibyte support disabled]) zsh_cv_c_unicode_support=no fi @@ -3299,4 +3300,16 @@ fi echo "See config.modules for installed modules and functions. " +if test x$zsh_cv_c_unicode_support != xyes; then + if test "x$zfuncs_absent" = x; then + # The user opted out. + AC_MSG_WARN([You have chosen to build without multibyte support.]) + AC_MSG_WARN([This configuration may not be suitable for production use. It is known to cause errors in 'make test'. We strongly recommend to re-run configure with --enable-multibyte.]) + else + # Some requisite functions are missing. + AC_MSG_WARN([Multibyte support disabled due to missing functions: $zfuncs_absent]) + AC_MSG_WARN([Building without multibyte support is strongly discouraged and may cause errors in 'make test'.]) + fi +fi + exit 0