From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 67e6e69a for ; Sun, 5 Jan 2020 19:14:13 +0000 (UTC) Received: (qmail 16331 invoked by alias); 5 Jan 2020 19:14:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45246 Received: (qmail 786 invoked by uid 1010); 5 Jan 2020 19:14:08 -0000 X-Qmail-Scanner-Diagnostics: from wout1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25684. spamassassin: 3.4.2. Clear:RC:0(64.147.123.24):SA:0(-2.6/5.0):. Processed in 7.171064 secs); 05 Jan 2020 19:14:08 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdegkedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesth dttddttdervdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudektddrheejrdduudelne curfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhn rghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Date: Sun, 5 Jan 2020 19:13:22 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) Message-ID: <20200105191322.s6yfdtpbpkvtkczk@tarpaulin.shahaf.local2> References: <20200101134457.kdzfrmlyzjwptxaz@tarpaulin.shahaf.local2> <64e62682e403332a89322b7f24983fa009c19fc0.camel@ntlworld.com> <46b2aa40-adcb-44ff-8e39-df98a9b2d235@www.fastmail.com> <1578046551.4581.1.camel@samsung.com> <20200103201102.o7ezzd6ccxxih7fb@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Peter Stephenson wrote on Sun, Jan 05, 2020 at 18:20:30 +0000: > On Fri, 2020-01-03 at 20:11 +0000, Daniel Shahaf wrote: > > Here's a draft. Probably needs wordsmithing. > > Sorry to be slow --- Definitely in the target area; I'm wondering about No worries; I wasn't going to commit this until after the weekend anyway. > > + # Some requisite functions are missing. > > + AC_MSG_WARN([Multibyte support disabled due to missing functions: $zfuncs_absent]) > > + AC_MSG_WARN([Building without multibyte support is strongly discouraged and may cause errors in 'make test'.]) > > where the user doesn't have a lot of choice about what they're building, > so discouraging it is a bit pointless. I'd be tempted to omit that bit > here. Fair point. How about: diff --git a/configure.ac b/configure.ac index 256584538..cd42a789e 100644 --- a/configure.ac +++ b/configure.ac @@ -2553,6 +2553,7 @@ wmemcpy wmemmove wmemset; do AC_MSG_NOTICE([all functions found, multibyte support enabled]) zsh_cv_c_unicode_support=yes else + # Warns at the end of configure AC_MSG_NOTICE([missing functions, multibyte support disabled]) zsh_cv_c_unicode_support=no fi @@ -3299,4 +3300,18 @@ fi echo "See config.modules for installed modules and functions. " +if test x$zsh_cv_c_unicode_support != xyes; then + if test "x$zfuncs_absent" = x; then + # The user opted out. + AC_MSG_WARN([You have chosen to build without multibyte support.]) + AC_MSG_WARN([This configuration may not be suitable for production use. It is known to cause errors in 'make test'. We strongly recommend to re-run configure with --enable-multibyte.]) + else + # Some requisite functions are missing. + AC_MSG_WARN([Multibyte support cannot be enabled: some standard library functions are missing: $zfuncs_absent]) + AC_MSG_WARN([This configuration may not be suitable for production use. It is known to cause errors in 'make test'. If your system provides those functions, we recommend to re-run configure appropriately.]) + # If your system doesn't have those functions, consider patching the + # test suite and sending the patch to zsh-workers@ for inclusion. + fi +fi + exit 0 (The "if" branch is unchanged.) Cheers, Daniel