zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <danielsh@apache.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] A glob with a trailing slash will now match unreadable/unexecutable directories.
Date: Mon, 13 Jan 2020 16:41:20 +0000	[thread overview]
Message-ID: <20200113164120.GA7398@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <E2CFE377-F8B5-457F-9C68-5EB6F4EE9985@dana.is>

dana wrote on Mon, Jan 13, 2020 at 00:24:22 -0600:
> A cool thing about it is that it apparently also fixes workers/42891 (globs
> misbehaving with sudo on macOS). Not sure if there are cases where it'd still
> be an issue, but a simple test (see below) run with root now passes where it
> wouldn't before.

Cool ☺  Please commit it, then.

> There is an issue with the D02 test you added before, though: Making the
> directories unwriteable prevents ztst from cleaning up properly afterwards
> (unless you're root), which causes other tests to fail the next time i run the
> script:

Thanks for the report.  Does appending $'%clean\n chmod +w
glob.tmp/secret*\n' to the file fix the issue?

To reduce communications overhead, feel free to go ahead and commit my
patch from the start of the thread [to 5.9, as per elsethread] with some
appropriate cleanup that makes it pass in your environment.

Cheers,

Daniel

  reply	other threads:[~2020-01-13 16:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200113002821eucas1p2884acfad76834011d777bf81f0562c50@eucas1p2.samsung.com>
2020-01-13  0:27 ` Daniel Shahaf
2020-01-13  6:24   ` dana
2020-01-13 16:41     ` Daniel Shahaf [this message]
2020-01-13  9:46   ` Peter Stephenson
2020-01-13 16:34     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113164120.GA7398@tarpaulin.shahaf.local2 \
    --to=danielsh@apache.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).