From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 738b4be0 for ; Mon, 13 Jan 2020 16:42:07 +0000 (UTC) Received: (qmail 14837 invoked by alias); 13 Jan 2020 16:42:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45296 Received: (qmail 27067 invoked by uid 1010); 13 Jan 2020 16:42:02 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25691. spamassassin: 3.4.2. Clear:RC:0(66.111.4.25):SA:0(-1.9/5.0):. Processed in 6.219182 secs); 13 Jan 2020 16:42:02 -0000 X-Envelope-From: danielsh@apache.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: softfail (ns1.primenet.com.au: transitioning SPF record at amazonses.com does not designate 66.111.4.25 as permitted sender) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdejtddgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderjeenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurghnihgvlhhs hhesrghprggthhgvrdhorhhgqeenucfkphepjeelrddukedtrdehjedrudduleenucfrrg hrrghmpehmrghilhhfrhhomhepuggrnhhivghlshhhsegrphgrtghhvgdrohhrghenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Date: Mon, 13 Jan 2020 16:41:20 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] A glob with a trailing slash will now match unreadable/unexecutable directories. Message-ID: <20200113164120.GA7398@tarpaulin.shahaf.local2> References: <20200113002724.12708-1-danielsh@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) dana wrote on Mon, Jan 13, 2020 at 00:24:22 -0600: > A cool thing about it is that it apparently also fixes workers/42891 (globs > misbehaving with sudo on macOS). Not sure if there are cases where it'd still > be an issue, but a simple test (see below) run with root now passes where it > wouldn't before. Cool ☺ Please commit it, then. > There is an issue with the D02 test you added before, though: Making the > directories unwriteable prevents ztst from cleaning up properly afterwards > (unless you're root), which causes other tests to fail the next time i run the > script: Thanks for the report. Does appending $'%clean\n chmod +w glob.tmp/secret*\n' to the file fix the issue? To reduce communications overhead, feel free to go ahead and commit my patch from the start of the thread [to 5.9, as per elsethread] with some appropriate cleanup that makes it pass in your environment. Cheers, Daniel