zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Martijn Dekker <martijn@inlv.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] sh/ksh init: don't initialise lowercase parameters
Date: Sat, 1 Feb 2020 09:42:16 +0000	[thread overview]
Message-ID: <20200201094216.01525b7f@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <b7e2e8a2-87a9-49c9-77ff-e612285b7a30@inlv.org>

I was going to apply the patch but I have two questions:

Martijn Dekker wrote on Tue, 28 Jan 2020 16:19 +0100:
> +++ b/Doc/Zsh/params.yo
> @@ -1173,8 +1173,8 @@ tt(histchars) to characters with a locale-dependent meaning will be
>  rejected with an error message.
>  )
>  vindex(HISTCHARS)
> -item(tt(HISTCHARS) <S> <Z>)(
> -Same as tt(histchars).  (Deprecated.)
> +item(tt(HISTCHARS) <S>)(
> +Same as tt(histchars).

Suggest to add ", but available in emulation modes too", otherwise
people will wonder whether the <Z> was omitted here by mistake.  I can
do that before applying the patch.

I intend to apply it to 5.9 unless there'll be another 5.8 test release
first.

> +++ b/Src/params.c
> @@ -309,7 +309,7 @@ IPDEF1("TTYIDLE", ttyidle_gsu, PM_READONLY_SPECIAL),
>  #define IPDEF2(A,B,C) {{NULL,A,PM_SCALAR|PM_SPECIAL|C},BR(NULL),GSU(B),0,0,NULL,NULL,NULL,0}
>  IPDEF2("USERNAME", username_gsu, PM_DONTIMPORT|PM_RESTRICTED),
>  IPDEF2("-", dash_gsu, PM_READONLY_SPECIAL),
> -IPDEF2("histchars", histchars_gsu, PM_DONTIMPORT),
> +IPDEF2("HISTCHARS", histchars_gsu, PM_DONTIMPORT),
>  IPDEF2("HOME", home_gsu, PM_UNSET),
>  IPDEF2("TERM", term_gsu, PM_UNSET),
>  IPDEF2("TERMINFO", terminfo_gsu, PM_UNSET),
> @@ -413,7 +413,7 @@ IPDEF8("MODULE_PATH", &module_path, "module_path", PM_DONTIMPORT|PM_RESTRICTED|P
>  
>  /* All of these have sh compatible equivalents.                */
>  IPDEF1("ARGC", argc_gsu, PM_READONLY_SPECIAL),
> -IPDEF2("HISTCHARS", histchars_gsu, PM_DONTIMPORT),
> +IPDEF2("histchars", histchars_gsu, PM_DONTIMPORT),
>  IPDEF4("status", &lastval),
>  IPDEF7("prompt", &prompt),
>  IPDEF7("PROMPT", &prompt),

What's the purpose of these two hunks?  They don't seem to have any build-time nor run-time effect?

Sorry for not spotting these two points earlier.

Daniel

      parent reply	other threads:[~2020-02-01  9:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200128152042eucas1p20cbbeeb7cbe5f6abff08128ba8792661@eucas1p2.samsung.com>
2020-01-28 15:19 ` Martijn Dekker
2020-01-28 15:26   ` Peter Stephenson
2020-01-28 15:45     ` Martijn Dekker
2020-01-29  8:49   ` Daniel Shahaf
2020-01-29 18:36     ` Bart Schaefer
2020-01-29 21:35       ` Daniel Shahaf
2020-01-29 22:00         ` Bart Schaefer
2020-01-31  4:17           ` Daniel Shahaf
2020-01-31  4:31             ` Bart Schaefer
2020-02-01  9:42   ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200201094216.01525b7f@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=martijn@inlv.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).