From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4e231fd5 for ; Sat, 1 Feb 2020 09:43:10 +0000 (UTC) Received: (qmail 12511 invoked by alias); 1 Feb 2020 09:43:02 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45369 Received: (qmail 19623 invoked by uid 1010); 1 Feb 2020 09:43:02 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25703. spamassassin: 3.4.2. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 4.241083 secs); 01 Feb 2020 09:43:02 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgedvgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkjghfofggtgfgsehtjedttdertddvnecuhfhrohhmpeffrghnihgv lhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenuc fkphepjeelrddukedtrdehjedrudduleenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Sat, 1 Feb 2020 09:42:16 +0000 From: Daniel Shahaf To: Martijn Dekker Cc: Zsh hackers list Subject: Re: [PATCH] sh/ksh init: don't initialise lowercase parameters Message-ID: <20200201094216.01525b7f@tarpaulin.shahaf.local2> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit I was going to apply the patch but I have two questions: Martijn Dekker wrote on Tue, 28 Jan 2020 16:19 +0100: > +++ b/Doc/Zsh/params.yo > @@ -1173,8 +1173,8 @@ tt(histchars) to characters with a locale-dependent meaning will be > rejected with an error message. > ) > vindex(HISTCHARS) > -item(tt(HISTCHARS) )( > -Same as tt(histchars). (Deprecated.) > +item(tt(HISTCHARS) )( > +Same as tt(histchars). Suggest to add ", but available in emulation modes too", otherwise people will wonder whether the was omitted here by mistake. I can do that before applying the patch. I intend to apply it to 5.9 unless there'll be another 5.8 test release first. > +++ b/Src/params.c > @@ -309,7 +309,7 @@ IPDEF1("TTYIDLE", ttyidle_gsu, PM_READONLY_SPECIAL), > #define IPDEF2(A,B,C) {{NULL,A,PM_SCALAR|PM_SPECIAL|C},BR(NULL),GSU(B),0,0,NULL,NULL,NULL,0} > IPDEF2("USERNAME", username_gsu, PM_DONTIMPORT|PM_RESTRICTED), > IPDEF2("-", dash_gsu, PM_READONLY_SPECIAL), > -IPDEF2("histchars", histchars_gsu, PM_DONTIMPORT), > +IPDEF2("HISTCHARS", histchars_gsu, PM_DONTIMPORT), > IPDEF2("HOME", home_gsu, PM_UNSET), > IPDEF2("TERM", term_gsu, PM_UNSET), > IPDEF2("TERMINFO", terminfo_gsu, PM_UNSET), > @@ -413,7 +413,7 @@ IPDEF8("MODULE_PATH", &module_path, "module_path", PM_DONTIMPORT|PM_RESTRICTED|P > > /* All of these have sh compatible equivalents. */ > IPDEF1("ARGC", argc_gsu, PM_READONLY_SPECIAL), > -IPDEF2("HISTCHARS", histchars_gsu, PM_DONTIMPORT), > +IPDEF2("histchars", histchars_gsu, PM_DONTIMPORT), > IPDEF4("status", &lastval), > IPDEF7("prompt", &prompt), > IPDEF7("PROMPT", &prompt), What's the purpose of these two hunks? They don't seem to have any build-time nor run-time effect? Sorry for not spotting these two points earlier. Daniel