zsh-workers
 help / color / mirror / Atom feed
* why can't we use "vared" in a subshell in interactive shells?
@ 2020-02-08 19:36 Stephane Chazelas
  2020-02-08 21:23 ` Bart Schaefer
  0 siblings, 1 reply; 4+ messages in thread
From: Stephane Chazelas @ 2020-02-08 19:36 UTC (permalink / raw)
  To: Zsh hackers list

Hi,

from
https://unix.stackexchange.com/questions/565718/zsh-timeout-for-vared-builtin/566442?noredirect=1#comment1053418_566442

In a script, both

vared myvar

and

(vared myvar)

work, but in an interactive shell, the latter doesn't:

$ (vared -c var)
vared: ZLE not enabled

Why?

The code indeed has:

    if ((interact && unset(USEZLE)) || !strcmp(term, "emacs")) {
        zwarnnam(name, "ZLE not enabled");
        return 1;
    }

And entersubsh() has

    opts[USEZLE] = 0;
    zleactive = 0;


-- 
Stephane

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: why can't we use "vared" in a subshell in interactive shells?
  2020-02-08 19:36 why can't we use "vared" in a subshell in interactive shells? Stephane Chazelas
@ 2020-02-08 21:23 ` Bart Schaefer
  2020-02-08 22:41   ` Stephane Chazelas
  2020-02-09  8:01   ` Stephane Chazelas
  0 siblings, 2 replies; 4+ messages in thread
From: Bart Schaefer @ 2020-02-08 21:23 UTC (permalink / raw)
  To: Zsh hackers list

On Sat, Feb 8, 2020 at 11:37 AM Stephane Chazelas <stephane@chazelas.org> wrote:
>
> $ (vared -c var)
> vared: ZLE not enabled
>
> Why?

Looks like an overlooked side-effect to me.  The assumption being made
is that in interactive mode, if USEZLE is false then it's because the
user has explicitly unsetopt'd it, not because it was temporarily
disabled on entry to a subshell.

There are two ways we could go here:
1) Assume that if the user has invoked vared, then it's OK to run ZLE
even if it was otherwise turned off, and just remove that test
entirely.  (The check for TERM == emacs is mostly obsolete anyway, if
we're attempting to do that we should be looking for [absense of]
certain terminfo values, not a specific terminal type.)
2) Figure out some way to remember the old state of USEZLE when
entering the subshell, and check that in bin_vared instead of checking
the current state.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: why can't we use "vared" in a subshell in interactive shells?
  2020-02-08 21:23 ` Bart Schaefer
@ 2020-02-08 22:41   ` Stephane Chazelas
  2020-02-09  8:01   ` Stephane Chazelas
  1 sibling, 0 replies; 4+ messages in thread
From: Stephane Chazelas @ 2020-02-08 22:41 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: Zsh hackers list

2020-02-08 13:23:46 -0800, Bart Schaefer:
[...]
> Looks like an overlooked side-effect to me.  The assumption being made
> is that in interactive mode, if USEZLE is false then it's because the
> user has explicitly unsetopt'd it, not because it was temporarily
> disabled on entry to a subshell.
> 
> There are two ways we could go here:
> 1) Assume that if the user has invoked vared, then it's OK to run ZLE
> even if it was otherwise turned off, and just remove that test
> entirely.  (The check for TERM == emacs is mostly obsolete anyway, if
> we're attempting to do that we should be looking for [absense of]
> certain terminfo values, not a specific terminal type.)
> 2) Figure out some way to remember the old state of USEZLE when
> entering the subshell, and check that in bin_vared instead of checking
> the current state.
[...]

Thanks.

The threads at https://www.zsh.org/mla/workers/2000/msg02518.html and 
http://www.zsh.org/mla/workers/2000/msg02367.html do bring some context.

(for the first one, the threading of messages on the website
seems broken, you can see the other messages in the discussion
at http://www.zsh.org/mla/workers/2000/date3.html)

-- 
Stephane

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: why can't we use "vared" in a subshell in interactive shells?
  2020-02-08 21:23 ` Bart Schaefer
  2020-02-08 22:41   ` Stephane Chazelas
@ 2020-02-09  8:01   ` Stephane Chazelas
  1 sibling, 0 replies; 4+ messages in thread
From: Stephane Chazelas @ 2020-02-09  8:01 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: Zsh hackers list

2020-02-08 13:23:46 -0800, Bart Schaefer:
> On Sat, Feb 8, 2020 at 11:37 AM Stephane Chazelas <stephane@chazelas.org> wrote:
> >
> > $ (vared -c var)
> > vared: ZLE not enabled
> >
> > Why?
> 
> Looks like an overlooked side-effect to me.  The assumption being made
> is that in interactive mode, if USEZLE is false then it's because the
> user has explicitly unsetopt'd it, not because it was temporarily
> disabled on entry to a subshell.
[...]

The main question here is probably "why is the zle option turned
off in subshells?". AFAICT, zle could only be invoked in
subshells for "vared".

The change (to turn zle off in subshells) is much older (2.5 in
1994).

-- 
Stephane

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-02-09  8:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 19:36 why can't we use "vared" in a subshell in interactive shells? Stephane Chazelas
2020-02-08 21:23 ` Bart Schaefer
2020-02-08 22:41   ` Stephane Chazelas
2020-02-09  8:01   ` Stephane Chazelas

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git