From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 39bfab5f for ; Sun, 16 Feb 2020 10:34:43 +0000 (UTC) Received: (qmail 7485 invoked by alias); 16 Feb 2020 10:34:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45439 Received: (qmail 13491 invoked by uid 1010); 16 Feb 2020 10:34:38 -0000 X-Qmail-Scanner-Diagnostics: from wout1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25718. spamassassin: 3.4.2. Clear:RC:0(64.147.123.24):SA:0(-2.6/5.0):. Processed in 0.886326 secs); 16 Feb 2020 10:34:38 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeggddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjfgesthektddttderjeenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cukfhppeejledrudejkedrjedrudekleenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Sun, 16 Feb 2020 10:34:02 +0000 From: Daniel Shahaf To: Chris Down Cc: zsh-workers@zsh.org Subject: Re: [PATCH v2 1/2] builtins: kill: Add basic test suite Message-ID: <20200216103402.GB15773@tarpaulin.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Chris Down wrote on Sat, Feb 15, 2020 at 20:20:55 -0400: > This is not totally comprehensive, but at least it's a start for the > core functionality. In the next commit, we'll also use this base to add > some regression tests. Thanks! I was only asking for regression tests, so unit tests are a pleasant surprise ☺ > + if zmodload zsh/system &>/dev/null; then > + ( > + trap 'exit 19' TERM > + kill $sysparams[pid] > + ) > + else > + print -u $ZTST_fd 'Cannot zmodload zsh/system, skipping kill with no sigspec' > + fi > +19:kill with no sigspec > + Shouldn't this set $ZTST_skip, rather than print? That variable is documented in Test/B01cd.ztst. +1 on the remainder of the file. Cheers, Daniel