From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-45458-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id ba886063
	for <ml@inbox.vuxu.org>;
	Tue, 18 Feb 2020 13:04:58 +0000 (UTC)
Received: (qmail 5896 invoked by alias); 18 Feb 2020 13:04:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45458
Received: (qmail 7632 invoked by uid 1010); 18 Feb 2020 13:04:51 -0000
X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2.  
 Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. 
 Processed in 3.74798 secs); 18 Feb 2020 13:04:51 -0000
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
X-ME-Sender: <xms:y-BLXv5b8PQcjF_TpsUz4eABWW3cgfOc5K-NP--8JWUa3tunwVOpLA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeekgdegkecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvuffkjghfofggtgfgsehtjedttdertddvnecuhfhrohhmpeffrghnihgv
    lhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenuc
    fkphepjeelrddujeekrdejrddukeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
    rghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv
X-ME-Proxy: <xmx:y-BLXpJUSvD68L5V2C0KVNG7oOu19CQoXWFK7hXUZ11895sLV2mZ5Q>
    <xmx:y-BLXhcb5GuIdP4b91vvAM9BWFDQlskJ7QwGV6AGFGMfm0b2qf9WcA>
    <xmx:y-BLXkc8qdryw9Q_Zi1DJTaN7ZXAF06kWNgr4vGxgTnEJfQWAriJcg>
    <xmx:y-BLXjTKFbVxrCRq13Yy3YbrultjhtLc1FOrG_WXy-rAd-KM5aGpjA>
Date: Tue, 18 Feb 2020 13:04:06 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Chris Down <chris@chrisdown.name>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test
 with explicit sigspec
Message-ID: <20200218130406.25b9c8e8@tarpaulin.shahaf.local2>
In-Reply-To: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name>
References: <c02a0a26bf4c82b1e227053337a4c71525504574.1581952273.git.chris@chrisdown.name>
	<9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Good morning Chris,

Chris Down wrote on Mon, 17 Feb 2020 10:12 -0500:
> The version without a sigspec can't be added yet because it would still
> kill the test runner even in expected-to-fail mode, see workers/45449
> for discussion. For the same reason, we use a signal which is non-fatal
> by default and unlikely to be sent by someone else, SIGURG, to do the
> expected-to-fail case prior to the fix.

Do you consider the rationale for using SIGURG important enough to be
added in a code comment?

I've pushed this series to master with prose changes only.

Thanks a lot!

Daniel