From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id cd2e233b for ; Tue, 18 Feb 2020 15:26:54 +0000 (UTC) Received: (qmail 24642 invoked by alias); 18 Feb 2020 15:26:45 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45459 Received: (qmail 26543 invoked by uid 1010); 18 Feb 2020 15:26:45 -0000 X-Qmail-Scanner-Diagnostics: from mail-qv1-f67.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2. Clear:RC:0(209.85.219.67):SA:0(-2.0/5.0):. Processed in 2.240234 secs); 18 Feb 2020 15:26:45 -0000 X-Envelope-From: chris@chrisdown.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.219.67 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WeZTHXAQ+ehAeZNe2dPyIaS0D46mN0KqQzQ06CB3tyk=; b=SowOi921e/2zwO6LDixbTCQFqql6PFGWOeUsTHvEPPVfosjGNkh4SL0oQKV2eroZXA TnnHFRdhejFNk6dap1DlJLRoiE8xn0eTKpuU6YTckUsUQCZZCnBxyDk6K4EJKLiCEUbZ sv/j3qZj/BUm/yu7DJPR/yBmU1RF1HR3g5eE5wZnErFt4tZs/EIzKZPzFVYgH3hH9oY/ s2b72RnbpebnwdupkM/XdRQbJzWi0/UVZNAh0blsH1p8DhJx7zi9iMiG8xpYISkJusHG QfZ4JOBZyDmHWp32BrLa1O2t1sy49O4hvdfFociFCgM88LfYpTkjlJtoBTNPqNVjx6Fq zDKA== X-Gm-Message-State: APjAAAU0xhYBwvS0cQLzqy83gu/ET2pq/0nZWap/23BZv1BiHSQmeUJS p5EfajAqOf0kVRba5IhMBpAguZP55fct8w== X-Google-Smtp-Source: APXvYqy7rdlI4TUw9cMGoZa1Fs5+KALjqMTxl7WsOd4UMJRyEgj0+4T7//80txRAyyP5qxbRCgjnSw== X-Received: by 2002:a0c:8605:: with SMTP id p5mr17137512qva.109.1582039569310; Tue, 18 Feb 2020 07:26:09 -0800 (PST) Date: Tue, 18 Feb 2020 10:26:08 -0500 From: Chris Down To: Daniel Shahaf Cc: zsh-workers@zsh.org Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Message-ID: <20200218152608.GA110547@chrisdown.name> References: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name> <20200218130406.25b9c8e8@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200218130406.25b9c8e8@tarpaulin.shahaf.local2> Morning! Daniel Shahaf writes: >Chris Down wrote on Mon, 17 Feb 2020 10:12 -0500: >> The version without a sigspec can't be added yet because it would still >> kill the test runner even in expected-to-fail mode, see workers/45449 >> for discussion. For the same reason, we use a signal which is non-fatal >> by default and unlikely to be sent by someone else, SIGURG, to do the >> expected-to-fail case prior to the fix. > >Do you consider the rationale for using SIGURG important enough to be >added in a code comment? Hmm, when I was considering whether to write it in the commit message or in the file, my rationale was that after 3/3 we're still going to end up killing the whole process group if it regresses, so likely the only people who'd run into this distinction are those doing `git bisect`. As such the commit message seemed the best place to me. I'm neutral though :-) >I've pushed this series to master with prose changes only. Thank you, and thanks for your diligent review! Chris