From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2a8426a3 for ; Tue, 18 Feb 2020 16:43:09 +0000 (UTC) Received: (qmail 17479 invoked by alias); 18 Feb 2020 16:43:04 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45460 Received: (qmail 29291 invoked by uid 1010); 18 Feb 2020 16:43:04 -0000 X-Qmail-Scanner-Diagnostics: from wout2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2. Clear:RC:0(64.147.123.25):SA:0(-2.6/5.0):. Processed in 4.200298 secs); 18 Feb 2020 16:43:04 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeekgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkjghfofggtgfgsehtjedttdertddvnecuhfhrohhmpeffrghnihgv lhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenuc fkphepjeelrddujeekrdejrddukeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Date: Tue, 18 Feb 2020 16:42:21 +0000 From: Daniel Shahaf To: Chris Down Cc: zsh-workers@zsh.org Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Message-ID: <20200218164221.14d2db80@tarpaulin.shahaf.local2> In-Reply-To: <20200218152608.GA110547@chrisdown.name> References: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name> <20200218130406.25b9c8e8@tarpaulin.shahaf.local2> <20200218152608.GA110547@chrisdown.name> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Chris Down wrote on Tue, 18 Feb 2020 10:26 -0500: > Daniel Shahaf writes: > >Chris Down wrote on Mon, 17 Feb 2020 10:12 -0500: > >> The version without a sigspec can't be added yet because it would still > >> kill the test runner even in expected-to-fail mode, see workers/45449 > >> for discussion. For the same reason, we use a signal which is non-fatal > >> by default and unlikely to be sent by someone else, SIGURG, to do the > >> expected-to-fail case prior to the fix. > > > >Do you consider the rationale for using SIGURG important enough to be > >added in a code comment? > > Hmm, when I was considering whether to write it in the commit message or in the > file, my rationale was that after 3/3 we're still going to end up killing the > whole process group if it regresses, so likely the only people who'd run into > this distinction are those doing `git bisect`. As such the commit message > seemed the best place to me. I'm neutral though :-) I understand, but I'm not convinced: 1. zsh's test suite aborts a test file as soon as any test group fails. Thus, if the bug regresses, the URG test will run but the TERM test won't. 2. The URG test may be copied and adapted. 3. The reasons for picking URG are of interest to anyone who reads the code (for whatever reason), even if few people will do so. > >I've pushed this series to master with prose changes only. > > Thank you, and thanks for your diligent review! You're welcome! Cheers, Daniel