From: Chris Down <chris@chrisdown.name>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec
Date: Tue, 18 Feb 2020 13:50:46 -0500 [thread overview]
Message-ID: <20200218185046.GA122780@chrisdown.name> (raw)
In-Reply-To: <20200218164221.14d2db80@tarpaulin.shahaf.local2>
Daniel Shahaf writes:
>I understand, but I'm not convinced:
>
>1. zsh's test suite aborts a test file as soon as any test group
>fails. Thus, if the bug regresses, the URG test will run but the TERM
>test won't.
Ah! Ok, I thought I saw that behaviour before but didn't think too much about
it. In which case yes, it's still valuable.
>2. The URG test may be copied and adapted.
>
>3. The reasons for picking URG are of interest to anyone who reads the
>code (for whatever reason), even if few people will do so.
Cool, you've convinced me. I'll put up a small patch.
Thanks!
Chris
next prev parent reply other threads:[~2020-02-18 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:11 [PATCH v3 1/3] builtins: kill: Add basic test suite Chris Down
2020-02-17 15:12 ` [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Chris Down
2020-02-17 15:12 ` [PATCH v3 3/3] builtins: kill: Do not signal current process group when pid is empty Chris Down
2020-02-18 13:04 ` [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Daniel Shahaf
2020-02-18 15:26 ` Chris Down
2020-02-18 16:42 ` Daniel Shahaf
2020-02-18 18:50 ` Chris Down [this message]
2020-02-18 19:37 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218185046.GA122780@chrisdown.name \
--to=chris@chrisdown.name \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).