From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 85dfcde7 for ; Tue, 18 Feb 2020 18:51:30 +0000 (UTC) Received: (qmail 10976 invoked by alias); 18 Feb 2020 18:51:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45462 Received: (qmail 10541 invoked by uid 1010); 18 Feb 2020 18:51:24 -0000 X-Qmail-Scanner-Diagnostics: from mail-qk1-f196.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2. Clear:RC:0(209.85.222.196):SA:0(-2.0/5.0):. Processed in 2.068658 secs); 18 Feb 2020 18:51:24 -0000 X-Envelope-From: chris@chrisdown.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.196 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8rFhVk+tUSKdkJNUvFeANC5+azoivhvEdwfOkLcIi7Q=; b=AbFhh/0+mIpSUaKPTdnvDBl+nMFNE+say8iOMqk3zn6q3JMo7+fQ+cOXbwN5V5JX/N 61b88arRgBZhfk8GmS/b632NAj6bMScE5tWUKfLOg7tcDTUpW1S8GqbztvVehDFNTxe/ N0BMGbcQQMiw/U8mJQOkSGF2+nRtUshkA07dFzrCn/8ZWEtS5YBUQ3ks80iL8FEINeC/ MJ6wZFE7TafWY2r8+v7v+4o2pB+x+hkfMvP55Hk9zAo4EDCWfuL88fixc+oKId0MYF6C m/IEitmjcg9ogiJDJ+XLYEbcm6mbHzR33YU7qG0d2a3TpJh/UBzj2w5SNaHuginu8bvI jHVQ== X-Gm-Message-State: APjAAAUpK5qwCRtH1EVat3ZNpzjmcNobdMqybGHhcJxn63PRAvUGsWKK VgJ4chB1A3FGuugy2j9to8aLjQ== X-Google-Smtp-Source: APXvYqyEfED18umybykwedFc8CBn2aGVS50wF34a+ERTITg+2sFUJyzRPc2fc0KfJOqd9PAvXsRmIA== X-Received: by 2002:a05:620a:c1a:: with SMTP id l26mr20698482qki.317.1582051847966; Tue, 18 Feb 2020 10:50:47 -0800 (PST) Date: Tue, 18 Feb 2020 13:50:46 -0500 From: Chris Down To: Daniel Shahaf Cc: zsh-workers@zsh.org Subject: Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Message-ID: <20200218185046.GA122780@chrisdown.name> References: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name> <20200218130406.25b9c8e8@tarpaulin.shahaf.local2> <20200218152608.GA110547@chrisdown.name> <20200218164221.14d2db80@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200218164221.14d2db80@tarpaulin.shahaf.local2> Daniel Shahaf writes: >I understand, but I'm not convinced: > >1. zsh's test suite aborts a test file as soon as any test group >fails. Thus, if the bug regresses, the URG test will run but the TERM >test won't. Ah! Ok, I thought I saw that behaviour before but didn't think too much about it. In which case yes, it's still valuable. >2. The URG test may be copied and adapted. > >3. The reasons for picking URG are of interest to anyone who reads the >code (for whatever reason), even if few people will do so. Cool, you've convinced me. I'll put up a small patch. Thanks! Chris