From: Chris Down <chris@chrisdown.name>
To: zsh-workers@zsh.org
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: [PATCH] test: kill: Document why we use SIGURG
Date: Tue, 18 Feb 2020 13:54:37 -0500 [thread overview]
Message-ID: <20200218185437.GA125346@chrisdown.name> (raw)
See discussion in workers/45460.
---
Test/B11kill.ztst | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
index 40dd99cd3..dc6bf9b89 100644
--- a/Test/B11kill.ztst
+++ b/Test/B11kill.ztst
@@ -60,6 +60,15 @@
?(eval):kill:2: not enough arguments
# Regression tests: `kill ''` should not result in `kill 0`.
+#
+# We use SIGURG where an explicit sigspec can be provided as:
+#
+# 1. By default it's non-terminal, so even if we regress, we won't kill the
+# test runner and other processes in the process group since we'll stop
+# running this test before we get to the plain kill (and thus SIGTERM)
+# cases;
+# 2. It's also unlikely to be sent for any other reason during the process
+# lifetime, so the test shouldn't be flaky.
(
trap 'exit 11' URG
--
2.25.0
reply other threads:[~2020-02-18 18:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218185437.GA125346@chrisdown.name \
--to=chris@chrisdown.name \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).