* [PATCH] test: kill: Document why we use SIGURG
@ 2020-02-18 18:54 Chris Down
0 siblings, 0 replies; only message in thread
From: Chris Down @ 2020-02-18 18:54 UTC (permalink / raw)
To: zsh-workers; +Cc: Daniel Shahaf
See discussion in workers/45460.
---
Test/B11kill.ztst | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
index 40dd99cd3..dc6bf9b89 100644
--- a/Test/B11kill.ztst
+++ b/Test/B11kill.ztst
@@ -60,6 +60,15 @@
?(eval):kill:2: not enough arguments
# Regression tests: `kill ''` should not result in `kill 0`.
+#
+# We use SIGURG where an explicit sigspec can be provided as:
+#
+# 1. By default it's non-terminal, so even if we regress, we won't kill the
+# test runner and other processes in the process group since we'll stop
+# running this test before we get to the plain kill (and thus SIGTERM)
+# cases;
+# 2. It's also unlikely to be sent for any other reason during the process
+# lifetime, so the test shouldn't be flaky.
(
trap 'exit 11' URG
--
2.25.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-18 18:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 18:54 [PATCH] test: kill: Document why we use SIGURG Chris Down
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).