From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d6a4588c for ; Tue, 18 Feb 2020 18:55:17 +0000 (UTC) Received: (qmail 24015 invoked by alias); 18 Feb 2020 18:55:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45463 Received: (qmail 18360 invoked by uid 1010); 18 Feb 2020 18:55:12 -0000 X-Qmail-Scanner-Diagnostics: from mail-qk1-f179.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25725. spamassassin: 3.4.2. Clear:RC:0(209.85.222.179):SA:0(-2.0/5.0):. Processed in 0.707219 secs); 18 Feb 2020 18:55:12 -0000 X-Envelope-From: chris@chrisdown.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.179 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=cUPplGgBHV95k4VdcljiYSrK3Ch3ucJT21H2lswvtiI=; b=nLYRwtjvsH0Vjx/i/6LVLyZ+xp1r+EAHOrMICA1X3BinK45Z/fWBKkwQyRRkCf3fq9 FaIVli/lnkHymr4EuCwkD36fYWSCCliDfOUjIqcPmDZYYElpsDp1Gbd8DWoYFa0esLG/ oGOPekA/QbhPEIYD58AUTeneh3wHcEcdKdwLot3j4WRsG3RqH8m9eX6N0ri4pBI52r6d cshBr99xpIkCc5/UXXvy0CrEsV6o2eEC9RQkLq2/JmuE5hueWzc//Ou7Qu/XbZSog6gE wOYc/dijgVsU5y3jfzRE3mXBxc0LHq6MGb2v3+lIQq9A4XhWf3v7fp2wlif0gJx/VuUD uYsQ== X-Gm-Message-State: APjAAAX5zrwCI4kSTaj1Z+jKUM7FPloO0Lgf9d8vIoiU+r22Nzy3gjvb krnF0yVd9bBQM+cWhY6L+uh+jgtnEBq0mQ== X-Google-Smtp-Source: APXvYqwRYmcJ2z2cFL4V4A/ug8xwFcm7DiAU0hDLMOzhLqum0J2H3wWfRp6K5vlm1dt5tQGS+ZpspA== X-Received: by 2002:a37:4dc4:: with SMTP id a187mr20567004qkb.436.1582052078700; Tue, 18 Feb 2020 10:54:38 -0800 (PST) Date: Tue, 18 Feb 2020 13:54:37 -0500 From: Chris Down To: zsh-workers@zsh.org Cc: Daniel Shahaf Subject: [PATCH] test: kill: Document why we use SIGURG Message-ID: <20200218185437.GA125346@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline See discussion in workers/45460. --- Test/B11kill.ztst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst index 40dd99cd3..dc6bf9b89 100644 --- a/Test/B11kill.ztst +++ b/Test/B11kill.ztst @@ -60,6 +60,15 @@ ?(eval):kill:2: not enough arguments # Regression tests: `kill ''` should not result in `kill 0`. +# +# We use SIGURG where an explicit sigspec can be provided as: +# +# 1. By default it's non-terminal, so even if we regress, we won't kill the +# test runner and other processes in the process group since we'll stop +# running this test before we get to the plain kill (and thus SIGTERM) +# cases; +# 2. It's also unlikely to be sent for any other reason during the process +# lifetime, so the test shouldn't be flaky. ( trap 'exit 11' URG -- 2.25.0