zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Unreadable directories aren't included in glob expansion
Date: Thu, 27 Feb 2020 13:00:17 +0000	[thread overview]
Message-ID: <20200227130017.2c0d48cd@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <228AACAF-6A76-417F-929A-0CC48A9AB1D0@kba.biglobe.ne.jp>

Jun. T wrote on Thu, 27 Feb 2020 00:51 +0900:
> (moved from users/24633⁩)
> 
> > 2020/01/11 2:09, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 
> > diff --git a/Test/D02glob.ztst b/Test/D02glob.ztst  
> (snip)
> > + mkdir -m 000 glob.tmp/secret-d000
> > + mkdir -m 111 glob.tmp/secret-d111
> > + mkdir -m 444 glob.tmp/secret-d444
> > + for 1 in 000 111 444 ; do ln -s secret-d$1 glob.tmp/secret-s$1; done
> > + print -rC 2 -- glob.tmp/secret-*/ glob.tmp/secret-*(-/)
> > +-f:unreadable directories can be globbed (users/24619, users/24626)  
> (snip)
> 
> This test fails on Cygwin, i.e., does not fail as expected.
> This is because stat("glob.tmp/secret-d000/.") succeeds on Cygwin.
> I asked about this in the cygwin mailing list and learned that
> this is the default behavior of Windows and it is not easy for
> Cygwin to override it.
> I think just skipping this test on Cygwin is enough for now.

I assume some day we'll fix the C code to make the test pass on other
platforms.  When that happens, should the test then continue be skipped
on Cygwin?  If not, I suggest adding a comment reminding to remove the
skip when the test starts to pass on other platforms.

Cheers,

Daniel

  reply	other threads:[~2020-02-27 13:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200109154313eucas1p13b2e5465f21d059ea08537012e140236@eucas1p1.samsung.com>
     [not found] ` <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2>
     [not found]   ` <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com>
     [not found]     ` <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com>
     [not found]       ` <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com>
     [not found]         ` <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2>
2020-02-26 15:51           ` Jun. T
2020-02-27 13:00             ` Daniel Shahaf [this message]
2020-02-28  6:37               ` Jun T
2020-02-28  6:51                 ` Bart Schaefer
2020-02-28  7:57                   ` Jun T
2020-02-28 14:26                 ` Daniel Shahaf
2020-02-28 14:55                   ` Daniel Shahaf
2020-03-03  1:57                     ` Jun T
2020-03-04 19:21                       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227130017.2c0d48cd@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).