From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a49d04a5 for ; Thu, 27 Feb 2020 13:01:15 +0000 (UTC) Received: (qmail 22970 invoked by alias); 27 Feb 2020 13:01:06 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45494 Received: (qmail 10271 invoked by uid 1010); 27 Feb 2020 13:01:06 -0000 X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25731. spamassassin: 3.4.2. Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. Processed in 4.79432 secs); 27 Feb 2020 13:01:06 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleeigdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhfogggtgfesthhqtd dtredtjeenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejkedrjedrudekleenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Thu, 27 Feb 2020 13:00:17 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: Unreadable directories aren't included in glob expansion Message-ID: <20200227130017.2c0d48cd@tarpaulin.shahaf.local2> In-Reply-To: <228AACAF-6A76-417F-929A-0CC48A9AB1D0@kba.biglobe.ne.jp> References: <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2> <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com> <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com> <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com> <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2> <228AACAF-6A76-417F-929A-0CC48A9AB1D0@kba.biglobe.ne.jp> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jun. T wrote on Thu, 27 Feb 2020 00:51 +0900: > (moved from users/24633=E2=81=A9) >=20 > > 2020/01/11 2:09, Daniel Shahaf wrote: > >=20 > > diff --git a/Test/D02glob.ztst b/Test/D02glob.ztst =20 > (snip) > > + mkdir -m 000 glob.tmp/secret-d000 > > + mkdir -m 111 glob.tmp/secret-d111 > > + mkdir -m 444 glob.tmp/secret-d444 > > + for 1 in 000 111 444 ; do ln -s secret-d$1 glob.tmp/secret-s$1; done > > + print -rC 2 -- glob.tmp/secret-*/ glob.tmp/secret-*(-/) > > +-f:unreadable directories can be globbed (users/24619, users/24626) =20 > (snip) >=20 > This test fails on Cygwin, i.e., does not fail as expected. > This is because stat("glob.tmp/secret-d000/.") succeeds on Cygwin. > I asked about this in the cygwin mailing list and learned that > this is the default behavior of Windows and it is not easy for > Cygwin to override it. > I think just skipping this test on Cygwin is enough for now. I assume some day we'll fix the C code to make the test pass on other platforms. When that happens, should the test then continue be skipped on Cygwin? If not, I suggest adding a comment reminding to remove the skip when the test starts to pass on other platforms. Cheers, Daniel