From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Thu, 27 Feb 2020 13:22:29 +0000 [thread overview]
Message-ID: <20200227132229.3e290918@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp>
Jun T wrote on Tue, 25 Feb 2020 18:38 +0900:
> Sorry for a *very* slow response; I've been quite busy these days.
> Finally I found some time to work on this.
No worries; we've all been there. I'm swamped/backlogged too.
> But removing rlimits.awk has one drawback:
> Before the patch, unknown resource can be detected in the build
> time (by the special make rule defined in rlimits.mdd).
> With the patch, we can notice unknown resouce(s) only when running
> the limit (or ulimit) builtin. We may hope that a user who sees
> UNKNOWN in the output of limit/ulimit will report it to us, or
> add a simple test like
>
> limit | grep UNKNOWN || print OK
>
> somewhere in the test (but in which .ztst file?).
I prefer a new test, but to arrange things in such a way that a failure
of the new test won't fail the build or prevent other tests from
running.
So, how about: —
1. Placing the test in a new file, V99nonfatal.ztst; and
2. Using «F:» lines to explain that when the test fails, that shouldn't
be treated as a build breaker and there is no problem to go on and do
«make install».
?
We might even add a new flag, e.g., «ZTST_failure_is_fatal=false», which
would cause «make test» to report the failure on stderr but keep the
exit code as zero: this way, if someone builds zsh 5.8 five years from
now on a 2025-vintage OS, their «make && make check && make install»
wouldn't fail on account of OS API changes between now and then.
A couple of minor issues spotted in read-through:
> --- a/Src/Builtins/rlimits.c
> +++ b/Src/Builtins/rlimits.c
> @@ -53,11 +40,214 @@ enum {
> +typedef struct {
Suggest to name the struct type — «typedef struct resinfo_t { … }
resinfo_t» — as that tends to result in prettier output in the debugger.
> +/* table of known resources */
> +static resinfo_t known_resources[] = {
Suggest to make the variable const.
I haven't had time yet to do a full review or to test this, I'm afraid ☹
Cheers,
Daniel
next prev parent reply other threads:[~2020-02-27 13:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf [this message]
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227132229.3e290918@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).